Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in notempty / endnotempty #27

Merged
merged 4 commits into from
Nov 20, 2019
Merged

Adding in notempty / endnotempty #27

merged 4 commits into from
Nov 20, 2019

Conversation

shanejones
Copy link
Contributor

Added a few extra directives for checking data against empty()

Given them a test locally and all works great.

@Log1x
Copy link
Owner

Log1x commented Nov 14, 2019

@empty already exists but I'm cool with adding a ! empty() equivalent.

I prefixed null with is such as @isnull and @isnotnull but seeing as in Laravel, @empty has no prefix– let's keep with their standards.

@notempty and @endnotempty?

@shanejones
Copy link
Contributor Author

Thanks for the feedback. PR is now updated.

@shanejones shanejones changed the title Adding in isempty / endisempty / isnotempty / endisnotempty Adding in notempty / endnotempty Nov 18, 2019
@Log1x
Copy link
Owner

Log1x commented Nov 18, 2019

No problem! Can you fix the indenting? I know prettifier/beautifier probably changed it on save as the indenting isn't exactly "traditional" with the directives (they are ugly lol)

sorry :x

@shanejones
Copy link
Contributor Author

shanejones commented Nov 19, 2019

That should now be updated for you.

@Log1x Log1x merged commit c9bdc17 into Log1x:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants