Use ubuntu-18.04 for GitHub actions due to an issue with the CosmosDb…

… emulator (see Azure/azure-cosmos-db-emulator-docker#45)
LogOtter · Nov 21, 2022 · 274b85d · 274b85d
1 parent a128818
commit 274b85d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/.github/workflows/commit.yml b/.github/workflows/commit.yml
@@ -8,7 +8,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04       # Use old version for now due to https://github.com/Azure/azure-cosmos-db-emulator-docker/issues/45
 
     steps:
       - name: Checkout

diff --git a/tests/LogOtter.CosmosDb.ContainerMock.IntegrationTests/Helpers/IntegrationTestsFixture.cs b/tests/LogOtter.CosmosDb.ContainerMock.IntegrationTests/Helpers/IntegrationTestsFixture.cs
@@ -9,7 +9,6 @@ namespace LogOtter.CosmosDb.ContainerMock.IntegrationTests;
 public class IntegrationTestsFixture : IAsyncLifetime
 {
     private readonly CosmosDbTestcontainer _container;
-    private bool _started;
 
     public IntegrationTestsFixture()
     {
@@ -20,11 +19,6 @@ public IntegrationTestsFixture()
 
     public TestCosmos CreateTestCosmos()
     {
-        if (!_started)
-        {
-            throw new Exception("ERROR: Container not started!");
-        }
-
         var cosmosClient = new CosmosClient(_container.ConnectionString, new CosmosClientOptions
         {
             ConnectionMode = ConnectionMode.Gateway,
@@ -37,7 +31,6 @@ public TestCosmos CreateTestCosmos()
     public async Task InitializeAsync()
     {
         await _container.StartAsync();
-        _started = true;
 
         if (Environment.GetEnvironmentVariable("GITHUB_ACTIONS") == "true")
         {