impl Zeroable for Atomic*
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation for some feature flags on the `Zeroable` trait. Also fixed some invalid references in doc-comments.
|
If I accept this as is it'll cause the same problem as happened before with #140, some platforms don't have atomics. However, the So unfortunately this has to be behind a cargo feature. I guess we'd maybe call it |
|
I see! Pushed a new commit with the feature flag. Documented the feature (and the other feature flags in that module) on the trait. Also, I saw that there was also some bad references in |
Lokathor
approved these changes
Dec 21, 2022
leod
pushed a commit
to leod/bytemuck
that referenced
this pull request
Jun 3, 2023
* `impl Zeroable for Atomic*` fixes Lokathor#74 * added feature flag for `zeroable_atomics` Added documentation for some feature flags on the `Zeroable` trait. Also fixed some invalid references in doc-comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #74