Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe_unsound_unstable_remove_static_asserts_for_coverage #89

Conversation

MaulingMonkey
Copy link
Contributor

More stable-friendly replacement for #88

Since this is a --cfg and not a feature, and it has a scary name, it should be quite difficult and unnecessary for libraries to accidentally relax soundness checks. It'd also be reasonable to ignore this PR and let people temporarilly patch their bytemuck downstream instead per MaulingMonkey/thindx@b6dd184 :

# Cargo.toml
[patch.crates-io]
bytemuck.git            = "https://github.com/MaulingMonkey/bytemuck"
bytemuck_derive.git     = "https://github.com/MaulingMonkey/bytemuck"
bytemuck.branch         = "pr-unsafe-unsound-unstable-remove-static-asserts-for-coverage"
bytemuck_derive.branch  = "pr-unsafe-unsound-unstable-remove-static-asserts-for-coverage"

@MaulingMonkey MaulingMonkey mentioned this pull request Jan 20, 2022
@Lokathor
Copy link
Owner

So this lets someone turn off some of the derive checks if they use the odd cfg expression?

If so, that sounds fine I guess. However, it looks like there's some small Cargo.toml conflicts that need a fixup.

@fu5ha
Copy link
Collaborator

fu5ha commented Mar 30, 2022

I think the point is for codecov bots to not mark the anonymous functions used for the static assertions as uncovered, I guess. But in addition to what Lok said, there's a couple more static asserts now that you'd want to add the #[cfg] to I believe :)

@Lokathor
Copy link
Owner

@MaulingMonkey looks like there's some conflicts that need fixing still

@Lokathor Lokathor closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants