Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new test and [must_use] fix #73

Merged
merged 4 commits into from
Jun 7, 2020
Merged

new test and [must_use] fix #73

merged 4 commits into from
Jun 7, 2020

Conversation

Soveu
Copy link
Sponsor Contributor

@Soveu Soveu commented May 28, 2020

Fixes #72

@Soveu
Copy link
Sponsor Contributor Author

Soveu commented May 30, 2020

I'm not quite happy with how the benchmarks are coded, maybe it will be a good idea just to delete them

@Lokathor
Copy link
Owner

Lokathor commented Jun 7, 2020

Well this also fixes some stuff, so we'll accept it for now and then we can update the benchmarks more later if we need to.

@Lokathor Lokathor merged commit 78fd946 into Lokathor:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lokathor Lokathor Lokathor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove [must_use] from functions that don't return anything
2 participants
@Soveu @Lokathor