Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tailwind and created Frontend Homepage #20

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

prathamVaidya
Copy link

Related Issue

Issue Number: #4 Frontend Needed

Description

Tasks Completed:

✔️ Desktop responsive Design. Can easily support Tablet as well with few breakpoints.
✔️ Sliders and other Components as per UI with required props.
✔️ Track State is managed.
✔️ Songs loading from dummy data.
✔️ Tracks are searchable.

Things that can be Improved and remaining features:

  1. Knob Buttons are not as per UI. The only knob react library requires a svg skin to make a knob button. So first we need to create a svg of the UI button and then create a skin and load in knob button. Check Docs here (Knob Skin Example: https://github.com/hugozap/react-rotary-knob-skin-pack/blob/master/skins/s14.js)
  2. Functionality to actually load tracks or songs in the player, extract metadata like duration, title, singer, etc. and play the track.
  3. Control State of all the sliders , knob buttons.
  4. Update Disc Animation. Use Framer Motion instead of css to get a seamless animation effect. (Use track time as animation delta)

Checkout Live Preview at https://rdj-exe.vercel.app

Screenshots

image

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for reactdj ready!

Name Link
🔨 Latest commit 7429e8d
🔍 Latest deploy log https://app.netlify.com/sites/reactdj/deploys/6482d1aec332850008890d9d
😎 Deploy Preview https://deploy-preview-20--reactdj.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @prathamVaidya! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project. We'll review your changes and provide feedback as soon as possible. Keep up the great work!

@prathamVaidya
Copy link
Author

@LokeshKumar-Dev Please provide a feedback on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant