Skip to content
This repository has been archived by the owner on Oct 1, 2019. It is now read-only.

Commit

Permalink
Add "Add" button for tags in "Used recently" and "Popular" (#430)
Browse files Browse the repository at this point in the history
  • Loading branch information
voidxnull committed Aug 7, 2016
1 parent 12e8c4c commit 0fbef5b
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 9 deletions.
2 changes: 2 additions & 0 deletions src/components/add-tag-modal/form/geotag/index.js
Expand Up @@ -111,6 +111,7 @@ export default class AddGeotagForm extends Component {
Used recently:
<div className="layout__row">
<TagCloud
addable
geotags={this.props.userRecentGeotags}
onClick={this._selectRecentlyUsedGeotag}
/>
Expand All @@ -121,6 +122,7 @@ export default class AddGeotagForm extends Component {
Popular:
<div className="layout__row">
<TagCloud
addable
geotags={popularGeotags}
/>
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/components/add-tag-modal/form/hashtag/index.js
Expand Up @@ -106,6 +106,7 @@ export default class AddHashtagForm extends Component {
Used recently:
<div className="layout__row">
<TagCloud
addable
hashtags={this.props.userRecentHashtags}
onClick={this._selectRecentlyUsedHashtag}
/>
Expand All @@ -116,6 +117,7 @@ export default class AddHashtagForm extends Component {
Popular:
<div className="layout__row">
<TagCloud
addable
hashtags={popularHashtags}
/>
</div>
Expand Down
6 changes: 5 additions & 1 deletion src/components/add-tag-modal/form/school/index.js
Expand Up @@ -115,6 +115,7 @@ export default class AddSchoolForm extends Component {
Used recently:
<div className="layout__row">
<TagCloud
addable
schools={this.props.userRecentSchools}
onClick={this._selectRecentlyUsedSchool}
/>
Expand All @@ -124,7 +125,10 @@ export default class AddSchoolForm extends Component {
<Tab.Content className={tabClassName} index={2}>
Popular:
<div className="layout__row">
<TagCloud schools={popularSchools} />
<TagCloud
addable
schools={popularSchools}
/>
</div>
</Tab.Content>
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/components/tag-cloud.js
Expand Up @@ -31,6 +31,7 @@ const TagCloud = (props) => {
const tags = convertModelsToTags(props)
.map((tag, index) => (
<Tag
addable={props.addable}
deletable={props.deletable}
key={index}
showPostCount={props.showPostCount}
Expand All @@ -51,6 +52,7 @@ const TagCloud = (props) => {
TagCloud.displayName = 'TagCloud';

TagCloud.propTypes = {
addable: PropTypes.bool,
deletable: PropTypes.bool,
geotags: ArrayOfGeotagsPropType,
hashtags: ArrayOfHashtagsPropType,
Expand Down
6 changes: 5 additions & 1 deletion src/components/tag.js
Expand Up @@ -28,6 +28,7 @@ export default class Tag extends React.Component {
static displayName = 'Tag';

static propTypes = {
addable: PropTypes.bool,
collapsed: PropTypes.bool,
deletable: PropTypes.bool,
inactive: PropTypes.bool,
Expand Down Expand Up @@ -155,7 +156,7 @@ export default class Tag extends React.Component {
return (
<div className={`tag ${className}`} title={name}>
<div className="tag__icon_wrapper">
<span className="micon tag__icon tag__delete clickable" onClick={this._handleDelete}>close</span>
<span className="micon tag__icon tag__action clickable" onClick={this._handleDelete}>close</span>
{tagIcon}
</div>
{tagNameComponent}
Expand All @@ -165,6 +166,9 @@ export default class Tag extends React.Component {
return (
<div className={`tag tag-clickable ${className}`} title={name} onClick={this._handleClick}>
<div className="tag__icon_wrapper">
{this.props.addable &&
<span className="micon tag__icon tag__action clickable">add</span>
}
{tagIcon}
</div>
{tagNameComponent}
Expand Down
14 changes: 7 additions & 7 deletions src/less/blocks/tag.less
Expand Up @@ -36,7 +36,7 @@
margin-left: 1px;

&:hover {
.tag__delete {
.tag__action {
opacity: 1;
}
}
Expand Down Expand Up @@ -104,7 +104,7 @@
color: @color__dark_gray;
}

&__delete {
&__action {
cursor: pointer;
line-height: @height;
opacity: 0;
Expand All @@ -119,39 +119,39 @@
&-hashtag {
border-color: #689ACA;

.tag__delete {
.tag__action {
background: #689ACA;
}
}

&-school {
border-color: #DC3457;

.tag__delete {
.tag__action {
background: #DC3457;
}
}

&-event {
border-color: #98C646;

.tag__delete {
.tag__action {
background: #98C646;
}
}

&-mention {
border-color: #F8A232;

.tag__delete {
.tag__action {
background: #F8A232;
}
}

&-location {
border-color: #47B8E7;

.tag__delete {
.tag__action {
background: #47B8E7;
}
}
Expand Down

0 comments on commit 0fbef5b

Please sign in to comment.