Skip to content
This repository has been archived by the owner on Oct 1, 2019. It is now read-only.

Commit

Permalink
Remove loadSchools trigger
Browse files Browse the repository at this point in the history
  • Loading branch information
voidxnull committed Jan 29, 2017
1 parent 57f9de1 commit bba36ae
Show file tree
Hide file tree
Showing 9 changed files with 5 additions and 44 deletions.
3 changes: 0 additions & 3 deletions src/pages/geotag-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ class GeotagEditPage extends React.Component {
return 404;
}

const trigger = new ActionsTrigger(client, store.dispatch);
await trigger.loadSchools();

return 200;
}

Expand Down
5 changes: 1 addition & 4 deletions src/pages/geotag.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,7 @@ export class UnwrappedGeotagPage extends Component {
store.dispatch(setGeotagPosts(router.params.url_name, await geotagPosts));

const trigger = new ActionsTrigger(client, store.dispatch);
Promise.all([
trigger.loadSchools(),
trigger.loadUserRecentTags()
]);
await trigger.loadUserRecentTags();

return 200;
}
Expand Down
3 changes: 0 additions & 3 deletions src/pages/hashtag-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ class HashtagEditPage extends React.Component {
return 404;
}

const trigger = new ActionsTrigger(client, store.dispatch);
await trigger.loadSchools();

return 200;
}

Expand Down
1 change: 0 additions & 1 deletion src/pages/list.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ export class UnwrappedListPage extends React.Component {
store.dispatch(clearRiver());

await Promise.all([
trigger.loadSchools(),
trigger.loadPostRiver(),
trigger.loadPersonalizedSuggestions(),
trigger.loadUserRecentTags()
Expand Down
10 changes: 0 additions & 10 deletions src/pages/post-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,7 @@ class PostEditPage extends React.Component {
};

static async fetchData(router, store, client) {
const noSchoolsLoaded = store.getState().get('schools').isEmpty();
const trigger = new ActionsTrigger(client, store.dispatch);
let schoolsPromise;

if (noSchoolsLoaded) {
schoolsPromise = trigger.loadSchools();
}

try {
const post = await client.postInfo(router.params.uuid);
Expand All @@ -86,10 +80,6 @@ class PostEditPage extends React.Component {
return 404;
}

if (noSchoolsLoaded) {
await schoolsPromise;
}

await trigger.loadUserRecentTags();
return 200;
}
Expand Down
7 changes: 1 addition & 6 deletions src/pages/school-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,10 @@ class SchoolEditPage extends React.Component {
const props = store.getState();
const trigger = new ActionsTrigger(client, store.dispatch);

const promises = [];
promises.push(trigger.loadSchools());

if (props.get('geo').get('countries').size === 0) {
promises.push(trigger.getCountries());
await trigger.getCountries();
}

await Promise.all(promises);

return 200;
}

Expand Down
6 changes: 2 additions & 4 deletions src/pages/school.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,8 @@ export class UnwrappedSchoolPage extends React.Component {
store.dispatch(setSchoolPosts(school, await posts));

const trigger = new ActionsTrigger(client, store.dispatch);
await Promise.all([
trigger.loadSchools(),
trigger.loadUserRecentTags()
]);
await trigger.loadUserRecentTags();


return 200;
}
Expand Down
5 changes: 1 addition & 4 deletions src/pages/tag.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,7 @@ export class UnwrappedTagPage extends Component {
store.dispatch(setHashtagPosts(router.params.tag, await tagPosts));

const trigger = new ActionsTrigger(client, store.dispatch);
Promise.all([
trigger.loadSchools(),
trigger.loadUserRecentTags()
]);
await trigger.loadUserRecentTags();

return 200;
}
Expand Down
9 changes: 0 additions & 9 deletions src/triggers/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -488,15 +488,6 @@ export class ActionsTrigger {
}
};

loadSchools = async () => {
try {
const result = await this.client.schools();
this.dispatch(a.schools.setSchools(result));
} catch (e) {
this.dispatch(a.messages.addError(e.message));
}
};

toolsLoadSchoolsRiver = async (query = {}, triggerUiChanges = true) => {
if (triggerUiChanges) {
this.dispatch(a.ui.setProgress('loadingSchoolsRiver', true));
Expand Down

0 comments on commit bba36ae

Please sign in to comment.