This repository has been archived by the owner on Oct 1, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidxnull
force-pushed
the
feature/recent-tags
branch
2 times, most recently
from
November 26, 2017 22:01
383f738
to
13bc944
Compare
Changes Unknown when pulling 13bc944 on feature/recent-tags into ** on stable**. |
voidxnull
force-pushed
the
feature/recent-tags
branch
from
November 26, 2017 22:11
13bc944
to
a49e5fb
Compare
Changes Unknown when pulling a49e5fb on feature/recent-tags into ** on stable**. |
Changes Unknown when pulling 6cf2296 on feature/recent-tags into ** on stable**. |
Changes Unknown when pulling 6cf2296 on feature/recent-tags into ** on stable**. |
voidxnull
force-pushed
the
feature/recent-tags
branch
from
December 6, 2017 02:07
6cf2296
to
353bbd5
Compare
voidxnull
force-pushed
the
feature/recent-tags
branch
from
December 6, 2017 02:23
353bbd5
to
f3760b9
Compare
Extracted most of the code to {TagType}.getRecentlyUsed so it can be reused.
voidxnull
force-pushed
the
feature/recent-tags
branch
from
December 6, 2017 02:24
f3760b9
to
a227215
Compare
voidxnull
force-pushed
the
feature/recent-tags
branch
2 times, most recently
from
December 10, 2017 13:21
91f5b4b
to
b15d32d
Compare
voidxnull
force-pushed
the
feature/recent-tags
branch
from
December 10, 2017 13:51
3651d62
to
486d097
Compare
voidxnull
force-pushed
the
feature/recent-tags
branch
3 times, most recently
from
December 11, 2017 05:06
13c6de4
to
a9009b8
Compare
Changed the signature of the applySomeQuery functions to be more intuitive and readable. Removed unnecessary async annotations.
Fixed possibility of SQL injection. Added table option.
Allows user to retrieve a total number of queried posts ignoring LIMIT and OFFSET. Opt-in for performance reasons.
Some tests check the order of schools. Comparing strings in js and pg yields different results.
voidxnull
force-pushed
the
feature/recent-tags
branch
from
December 11, 2017 05:23
a9009b8
to
86ce717
Compare
voidxnull
force-pushed
the
feature/recent-tags
branch
from
December 11, 2017 05:34
86ce717
to
5c307de
Compare
artkravchenko
approved these changes
Dec 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#951
getRecentlyUsedTags
controller (/api/v1/recent-tags
). Cached with redis.allPosts
:totalCount
query param)tagType
filterdateRange
filtergetRecentlyUsedTags
.