Refactored Help command #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work in progress - found that some tests failed and then wanted to activate strict mode. (test was circular dependency + added hej test) |
Samev
reviewed
Jul 28, 2021
Samev
reviewed
Jul 28, 2021
Samev
reviewed
Jul 28, 2021
Samev
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on other pull request - merge first)
Help commands moved to new format
Had to split them up due to Discord limitation, refactored code so that was easier
Added so help detailed functionality is implementable (so we can write more detailed help explanations if we want to. These are seen by the helpall command).
Tweaks from the previous refactor of commands
Moved types to a new file for the BaseCommands to follow that convention
Added ability to set if a message should be parsable in direct message or not (Supply the types you want) - So help command is example of this (works in server and DM)