forked from django/django
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Async builtin view decorators 2 #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @LomaxOnTheRun! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
LomaxOnTheRun
force-pushed
the
async-builtin-view-decorators-2
branch
4 times, most recently
from
July 8, 2022 21:41
d5273d9
to
4bd0a9c
Compare
27 tasks
LomaxOnTheRun
force-pushed
the
async-builtin-view-decorators-2
branch
2 times, most recently
from
July 16, 2022 21:12
f67dffa
to
461d80c
Compare
Co-authored-by: Hendrik Frentrup <hendrik.frentrup@gmail.com>
LomaxOnTheRun
force-pushed
the
async-builtin-view-decorators-2
branch
2 times, most recently
from
July 17, 2022 21:42
46a1540
to
09b6b72
Compare
LomaxOnTheRun
force-pushed
the
async-builtin-view-decorators-2
branch
from
July 17, 2022 21:47
09b6b72
to
2dc8d8c
Compare
LomaxOnTheRun
force-pushed
the
async-builtin-view-decorators-2
branch
from
July 20, 2022 19:41
2dc8d8c
to
6f1da13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR just so I can see the diffs more clearly, and can track thoughts and issues in the PR description.
Decorators:
@cache_page
(usesdecorator_from_middleware_with_args
)@cache_control
@never_cache
@xframe_options_deny
@xframe_options_sameorigin
@xframe_options_exempt
no_append_slash
@csrf_protect
(usesdecorator_from_middleware
)@requires_csrf_token
(usesdecorator_from_middleware
)@ensure_csrf_cookie
(usesdecorator_from_middleware
)@csrf_exempt
@sensitive_variables
sync_async_wrapper
can't be used because it requires arequest
positional argument.@sensitive_post_parameters
@gzip_page
(usesdecorator_from_middleware
)conditional_page
(usesdecorator_from_middleware
)@require_http_methods
@require_GET
@require_POST
@require_safe
@condition
get_conditional_response
function which will need to be made async@etag
get_conditional_response
function which will need to be made async@last_modified
get_conditional_response
function which will need to be made async@vary_on_headers
@vary_on_cookie