Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #338: Update "Add" menu on component change in fileNavigator #348

Merged
merged 4 commits into from
Mar 23, 2019

Conversation

vldmrkl
Copy link
Contributor

@vldmrkl vldmrkl commented Mar 21, 2019

This PR contains fix for #338.

It updates the list of components in the "Add menu" on any of the following actions:

  • A new component was created
  • Component was moved
  • Component was deleted

GIFs for each case:

add-component

move-component

delete-component

Copy link
Member

@dabbott dabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is looking great.

studio/LonaStudio/Workspace/WorkspaceViewController.swift Outdated Show resolved Hide resolved
studio/LonaStudio/Workspace/LayerListHeader.swift Outdated Show resolved Hide resolved
@dabbott
Copy link
Member

dabbott commented Mar 23, 2019

Nice! Great job 😄. This was one of my biggest pain points when starting a new Lona workspace, so super glad to have it in.

Looks like I'm gonna have to find some more issues 😂

@dabbott dabbott merged commit 761ecc3 into Lona:master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants