Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with examples of progress_callback #1396

Closed
Aeres-u99 opened this issue Feb 27, 2020 · 4 comments
Closed

Update docs with examples of progress_callback #1396

Aeres-u99 opened this issue Feb 27, 2020 · 4 comments

Comments

@Aeres-u99
Copy link

I am trying to run my program which basically downloads media from a channel.
The code snippet from quickstart section

if message.video:
▏   path = await message.download_media(progress_callback(total))
▏   print("Saved: ",path)

this helps me in downloading the file but does not displays the progress.
From referring to the docs I could find this, but I am unable to understand how to use the callback for the purpose. Kindly provide me with an explanation.
download_media()

@Aeres-u99 Aeres-u99 changed the title Download progress bar Progress bar when downloading media Feb 27, 2020
@Lonami Lonami changed the title Progress bar when downloading media Update docs with examples of progress_callback Feb 27, 2020
@Lonami
Copy link
Member

Lonami commented Feb 28, 2020

For the record, since you left so promptly

<kei> greetings 😅
<kei> @lonami I had created the progress bar related issue, can you provide me with the syntax for it so that I can roll in action and finish my small project? i just dont understand how to use the callback.
<lonami> preferable if you don't ping me for how to use the lib
<kei> yeah you are correct. I should better bang my head against wall than to ask for help or ask someone to write somewhat better documentation.
<lonami> my point is you can ask the group (here or @telethonchat) or even stackoverflow without the need to ping anyone
<lonami> and they left
<lonami> ah well

@Aeres-u99
Copy link
Author

It would have been much easier for you to convery the way without making fusses about it. True it might be rtfm type of issue, agreed that it could be asked on stackoverflow (which happens to have older version of telethon's answer btw) and I would love to know why you have not told me about the @telethonchat upon asking you twice. Nevertheless, Apologies for bothering you and wasting your time.

@Lonami
Copy link
Member

Lonami commented Feb 28, 2020

Issues are for either bug reports or enhancements, not asking for support on how to use the library directly. For that, there are groups, and the groups exist because I don't want people asking me directly the questions (or pinging me, for that matter).

If StackOverflow has outdated questions, leave a comment saying that it no longer works and it should be updated, or ask a new question "how to do foo in Telethon 1.11".

The group chat for specific Telethon questions can be found trying to create a new issue https://github.com/LonamiWebs/Telethon/issues/new/choose and following the " Find about updates and our Telegram groups" link. I also had no chance to mention the group because you left so hastily…

Lonami added a commit that referenced this issue Feb 28, 2020
@Lonami Lonami closed this as completed Feb 28, 2020
@Aeres-u99
Copy link
Author

isn't it an enhancement to the documentation? Also, instead of pointing out do no ping me, you could have said ask in @foobar and do not ping me. Nevertheless, its fixed and thats all I needed anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants