Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new errors to the list #1265

Merged
merged 14 commits into from Sep 10, 2019
Merged

Add new errors to the list #1265

merged 14 commits into from Sep 10, 2019

Conversation

davtur19
Copy link
Contributor

@davtur19 davtur19 commented Sep 6, 2019

REACTION_INVALID, SECONDS_INVALID, SCHEDULE_TOO_MUCH

Copy link
Member

@Lonami Lonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also update methods.csv and make these description read more like English? (Currently they are like the error, but lowercase and underscores becoming spaces):

  • The provided reaction was invalid (you can only use emoji)
  • You have scheduled too many messages in this chat (the maximum is ???)
  • The amount of seconds is invalid (too low? too high? When does this error happen?)

@Lonami
Copy link
Member

Lonami commented Sep 10, 2019

Found a new one: telethon.errors.rpcbaseerrors.BadRequestError: RPCError 400: SCHEDULE_DATE_TOO_LATE (caused by SendMessageRequest). Heh.

Copy link
Member

@Lonami Lonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to submit this review before :(

telethon_generator/data/errors.csv Outdated Show resolved Hide resolved
telethon_generator/data/errors.csv Outdated Show resolved Hide resolved
telethon_generator/data/errors.csv Outdated Show resolved Hide resolved
davtur19 and others added 3 commits September 10, 2019 20:57
Co-Authored-By: Lonami <totufals@hotmail.com>
Co-Authored-By: Lonami <totufals@hotmail.com>
Co-Authored-By: Lonami <totufals@hotmail.com>
@Lonami Lonami merged commit 95ba02a into LonamiWebs:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants