Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new errors to the list #1265

Merged
merged 14 commits into from Sep 10, 2019

Conversation

@davtur19
Copy link
Contributor

commented Sep 6, 2019

REACTION_INVALID, SECONDS_INVALID, SCHEDULE_TOO_MUCH

davtur19 added 5 commits Sep 6, 2019
Merge pull request #1 from davtur19/patch-1
Add REACTION_INVALID
Merge pull request #2 from davtur19/patch-2
Add SECONDS_INVALID
@Lonami
Copy link
Member

left a comment

Thanks! Could you also update methods.csv and make these description read more like English? (Currently they are like the error, but lowercase and underscores becoming spaces):

  • The provided reaction was invalid (you can only use emoji)
  • You have scheduled too many messages in this chat (the maximum is ???)
  • The amount of seconds is invalid (too low? too high? When does this error happen?)
davtur19 added 4 commits Sep 6, 2019
ops
ops
@Lonami

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Found a new one: telethon.errors.rpcbaseerrors.BadRequestError: RPCError 400: SCHEDULE_DATE_TOO_LATE (caused by SendMessageRequest). Heh.

Lonami added 2 commits Sep 10, 2019
@Lonami
Copy link
Member

left a comment

I forgot to submit this review before :(

telethon_generator/data/errors.csv Outdated Show resolved Hide resolved
telethon_generator/data/errors.csv Outdated Show resolved Hide resolved
telethon_generator/data/errors.csv Outdated Show resolved Hide resolved
davtur19 and others added 3 commits Sep 10, 2019
Update telethon_generator/data/errors.csv
Co-Authored-By: Lonami <totufals@hotmail.com>
Update telethon_generator/data/errors.csv
Co-Authored-By: Lonami <totufals@hotmail.com>
Update telethon_generator/data/errors.csv
Co-Authored-By: Lonami <totufals@hotmail.com>

@Lonami Lonami merged commit 95ba02a into LonamiWebs:master Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.