Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoplite's Discipline promotion only adds 15% once instead of for each adjacent friendly unit. #8349

Closed
ridjack opened this issue Oct 25, 2021 · 1 comment

Comments

@ridjack
Copy link

ridjack commented Oct 25, 2021

1.1.3

image
image

Aqinu pushed a commit to Aqinu/Community-Patch-DLL that referenced this issue Nov 7, 2021
Grand Temple fix LoneGazebo#8295
Hoplite Discipline fix LoneGazebo#8349
@LessRekkless
Copy link
Collaborator

<Replace>
<Type>PROMOTION_ADJACENT_BONUS</Type>
<Description>TXT_KEY_PROMOTION_DISCIPLINE</Description>
<Help>TXT_KEY_PROMOTION_DISCIPLINE_HELP</Help>
<Sound>AS2D_IF_LEVELUP</Sound>
<CombatPercent>10</CombatPercent>
<CannotBeChosen>true</CannotBeChosen>
<AdjacentMod>15</AdjacentMod>
<PortraitIndex>59</PortraitIndex>
<IconAtlas>ABILITY_ATLAS</IconAtlas>
<PediaType>PEDIA_SHARED</PediaType>
<PediaEntry>TXT_KEY_PROMOTION_DISCIPLINE</PediaEntry>
</Replace>

The Discipline promotion uses AdjacentMod instead of UnitPromotions_CombatModPerAdjacentUnitCombat
INSERT INTO UnitPromotions_CombatModPerAdjacentUnitCombat
(PromotionType, UnitCombatType, Modifier, Attack, Defense)
VALUES
('PROMOTION_ENCIRCLEMENT', 'UNITCOMBAT_NAVALMELEE', 0, 10, 0),
('PROMOTION_ENCIRCLEMENT', 'UNITCOMBAT_CARRIER', 0, 10, 0),
('PROMOTION_ENCIRCLEMENT', 'UNITCOMBAT_NAVALRANGED', 0, 10, 0),
('PROMOTION_ENCIRCLEMENT', 'UNITCOMBAT_SUBMARINE', 0, 10, 0),
('PROMOTION_BREACHER', 'UNITCOMBAT_NAVALMELEE',0, 0, 10),
('PROMOTION_BREACHER', 'UNITCOMBAT_CARRIER',0, 0, 10),
('PROMOTION_BREACHER', 'UNITCOMBAT_NAVALRANGED',0, 0, 10),
('PROMOTION_BREACHER', 'UNITCOMBAT_SUBMARINE',0, 0, 10);

@ridjack ridjack changed the title Hoplite's Discipline promotion only adds 15% once instead of for adjacent each friendly unit. Hoplite's Discipline promotion only adds 15% once instead of for each adjacent friendly unit. Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants