Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.4 Promotion "reduce damage taken from interception by 50%" works incorrect when attacking cities #9627

Closed
alchx opened this issue Jan 15, 2023 · 6 comments · Fixed by #9628
Assignees

Comments

@alchx
Copy link

alchx commented Jan 15, 2023

1. Mod Version (X.Y.Z). Current Version: 3.1.1

2. DirectX Version

3. List of Other Mods

4. Describe the Issue


5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)

--oh-bombers-- AD-1992.zip

6. Logs (ALWAYS ATTACH THESE IF POSSIBLE)

7. CvMiniDump.dmp File (ATTACH IF REPORTING A GAME CRASH)

8. Steps to reproduce the Issue (Optional)

Bombers with this promotion take 50% more damage instead of a 50% reduction when attacking cities.
When attacking land and water units, promotion works correctly and reduces damage taken by 50%.

screenshot 1-2 - city bomber with promotion (takes 45)
screenshot 3 - city bomber without promotion (takes 30)
screenshot 4 - interceptor fighter (takes 30)
screenshot 5 - reconnaissance fighter (takes 30)
screenshot 6 - assault bomber (takes 30)

9. Screenshots of the Issue (Optional)
20230115194651_1

20230115194556_1

20230115194910_1

20230115194730_1

20230115194713_1

20230115194629_1

@azum4roll
Copy link
Collaborator

I don't see anything that intercepts

@alchx
Copy link
Author

alchx commented Jan 18, 2023

I don't see anything that intercepts

The city itself is an interception point. A bomber with an promotion should take 15 damage instead of 45. A non-promoted bomber (and a fighter) takes 30 damage.

Against land units and ships (non-interceptors - infantry, battleships) that have received the Air Defense promotion, the bomber takes half damage (37 instead of 75 in the extreme case).

@LessRekkless
Copy link
Collaborator

LessRekkless commented Jan 18, 2023

@ilteroi in the 2019 12-20 patch, the InterceptionDefenseDamageModifier promotion ability was changed to be a damage reduction during an air strike in general, whether the unit was intercepted or not. The promotion text was not changed.

There is a sign error in the calculation for damage from the city. I'll get a fix for this.

@LessRekkless LessRekkless self-assigned this Jan 18, 2023
LessRekkless added a commit to LessRekkless/Community-Patch-DLL that referenced this issue Jan 18, 2023
 - InterceptionDefenseDamageModifier is a negative value when positive, so CvCity::GetAirStrikeDefenseDamage() has the wrong sign
 - damage reduction during interception was changed in the 12-20 patch (faf7c1) to be for air strikes in general; updated promotion text to clarify
 - this only takes place in VP, not CP
 - fixes LoneGazebo#9627
@azum4roll
Copy link
Collaborator

That's still not interception. But I guess the promotion affects both interception and normal taken damage now. Which is seriously strong.

@alchx
Copy link
Author

alchx commented Jan 19, 2023

That's still not interception. But I guess the promotion affects both interception and normal taken damage now. Which is seriously strong.

Units with promotion "Air Defense 3" deals 75 damage to attacking aircraft. Without reducing the damage taken by 50%, I have no idea how you can use aircraft against such units. Even after receiving 37 damage, it takes 4 turns to repair the damage received. Bombers do not have the 'active repairs' promotion that fighters have. And fighters don't have '50% damage reduction'

@azum4roll
Copy link
Collaborator

You don't attack those units. Find some other units without Air Defense.
If everything has Air Defense they should be lacking in normal promotions. Just roll over them with melee in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants