Open YouTube video on a browser or YouTube app (iOS only) #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he title or the YouTube logo on the player
liamjones
approved these changes
Jun 29, 2023
src/YoutubeIframe.js
Outdated
| const isYouTubeLink = url.startsWith('https://www.youtube.com/'); | ||
| if (isYouTubeLink) { | ||
| Linking.openURL(url).catch(error => { | ||
| console.error('Error opening URL:', error); |
There was a problem hiding this comment.
I think I'd probably make this a console.warn rather than an error
There was a problem hiding this comment.
I think you are right. I've updated and pushed.
…be opened. #codereviewchanges
LonelyCpp
approved these changes
Jul 1, 2023
|
looks good :) |
|
this has been published with v2.3.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #220 , so that a user can open YouTube video on a browser or YouTube app by tapping on the title or the YouTube logo on the player.
The reason why it works on Android is mentioned here. https://github.com/react-native-webview/react-native-webview/releases/tag/v11.0.0