-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Steam Unified #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to alot of the leg work. This allows the adapter classes be less work to maintain.
Steam is starting to use a new login flow, so we're gunna prepare for this. SteamKit currently has a PR in draft figuring out how to implement this new login style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Throwing this here as an initial start to see if any eyes looking at this can maybe help improve this.
I managed to tinker around and get a working implementation of Steam Unified Messages.
It seems Java lacks some features compared to C# (SteamKit) to do some reflection magic to get the calling method within lambda, among other things possibly (or that I lack skillset wise), to cut down on some boilerplate.
Example, Steamkit can extract the a method call from a lamba, in which
sendmessage
passes down to be extracted, then uses reflection to build it all neatly in one method.vs
After a few weeks of trying anything that I've learned, it appears Java cannot do it, so we have to make an adapter class to implement IPlayer, and pass everything though there.
However; building the Unified Message directly is on par with Steamkit, so thats a plus! :)
The interfaces need to be changed to return
JobID
, which is no biggie, while the "adapter" classes need to be built manually or generated with a groovy scriptChecks off
Steam Unified
in #181 as the functionality is implemented.Checklist