added user validation stuff #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add username to seed data file
adrianHards
previously approved these changes
Jun 14, 2023
There was a problem hiding this comment.
like model file not the latest version, did you pull latest?
I made one small change to the seed data file (didn't have a username). Happy to approve but think there's room for some more unit tests;
- trying to create a user with an existing email address
- trying to create a user with an existing username
- password validations (too short, white spaces, etc.)
- unable to create a user with an invalid username/password/email address
We can make this a separate ticket though.
adrianHards
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Happy to approve but think there’s room for some more unit tests;
- trying to create a user with an existing email address
- trying to create a user with an existing username
- password validations (too short, white spaces, etc.)
- unable to create a user with an invalid username/password/emaill address
We can make this a separate ticket though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.