docs: Adjustments for length #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xhiroshi
reviewed
Jan 20, 2023
| @@ -460,7 +460,8 @@ contract LooksRareProtocol is | |||
| ) internal { | |||
| if (totalProtocolFeeAmount != 0) { | |||
| if (affiliate != address(0)) { | |||
| // Check whether affiliate program is active and whether to execute a affiliate logic (and adjust downward the protocol fee if so) | |||
| // Check whether affiliate program is active and whether to execute a affiliate logic | |||
There was a problem hiding this comment.
Suggested change
| // Check whether affiliate program is active and whether to execute a affiliate logic | |
| // Check whether the affiliate program is active and whether to execute the affiliate logic |
0xhiroshi
reviewed
Jan 20, 2023
contracts/LooksRareProtocol.sol
Outdated
| @@ -460,7 +460,8 @@ contract LooksRareProtocol is | |||
| ) internal { | |||
| if (totalProtocolFeeAmount != 0) { | |||
| if (affiliate != address(0)) { | |||
| // Check whether affiliate program is active and whether to execute a affiliate logic (and adjust downward the protocol fee if so) | |||
| // Check whether affiliate program is active and whether to execute a affiliate logic | |||
| // If so, it adjusts downward the protocol fee. | |||
There was a problem hiding this comment.
Suggested change
| // If so, it adjusts downward the protocol fee. | |
| // If so, it adjusts the protocol fee downward. |
0xhiroshi
reviewed
Jan 20, 2023
| @@ -221,7 +221,8 @@ contract OrderValidatorV2A { | |||
|
|
|||
| validationCodes[0] = _checkValidityMakerAskWhitelists(makerAsk.currency, makerAsk.strategyId); | |||
|
|
|||
| // It can exit here if the strategy doesn't exist. However, if the strategy isn't valid, it can continue the execution. | |||
| // It can exit here if the strategy does not exist. | |||
| // However, if the strategy is not valid, it can continue the execution. | |||
There was a problem hiding this comment.
Maybe make not valid invalid to shorten it further
0xhiroshi
reviewed
Jan 20, 2023
| @@ -507,7 +509,8 @@ contract OrderValidatorV2A { | |||
| * @param collection Address of the collection | |||
| * @param assetType Asset type in the maker order | |||
| * @return validationCode Validation code | |||
| * @dev This function may return false positives (i.e. assets that are tradable but don't implement the proper interfaceId). Use with care. | |||
| * @dev This function may return false positives | |||
| // (i.e. assets that are tradable but do not implement the proper interfaceId). | |||
0xhiroshi
approved these changes
Jan 20, 2023
0xJurassicPunk
force-pushed
the
docs-update-120
branch
from
9a0a7a2
to
66ebcca
Compare
0xhiroshi
reviewed
Jan 23, 2023
| @@ -86,8 +86,13 @@ contract ExecutionManager is InheritedStrategy, NonceManager, StrategyManager, I | |||
| } | |||
|
|
|||
| /** | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
@0xJurassicPunk yoooooo 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.