feat: Split orders by referrer #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing private function
0xhiroshi
changed the title
0xhiroshi
reviewed
Jun 7, 2023
0xhiroshi
reviewed
Jun 7, 2023
0xhiroshi
reviewed
Jun 7, 2023
0xhiroshi
reviewed
Jun 7, 2023
Co-authored-by: Hiroshi <108636367+0xhiroshi@users.noreply.github.com>
…c/__tests__/aggregatorExecuteLooksRareV2.test.ts Co-authored-by: Hiroshi <108636367+0xhiroshi@users.noreply.github.com>
0xhiroshi
approved these changes
Jun 8, 2023
0xBunta
merged commit 7601fe1
into
LooksRare:feat/split-orders-by-referrer
3 checks passed
0xhiroshi
added a commit
that referenced
this pull request
Jun 8, 2023
* chore: Referrer type add to MakerOrderFromAPI * chore: Split looksRareV2 orders by referrer address inside transformListings * refactor: Move order separation logic inside transformLooksRareV2Listing private function * chore: add in referrer to transformLooksRareV2Listings * test: Test fixes after referrer split * test: Refactor tests to be fit for order split testing * test: groups orders with different referrers into different TradeData * test: group orders into TradData tests * test: execute multiple orders * fix: Push to tradeData instead of replace * fix: Change looksRareTradeData name to looksRareV2Listings * fix: Update spacing in comment in src/LooksRareAggregator.ts * fix: makerOrderFromAPIs to makerOrdersFromAPI naming fix in Update src/__tests__/aggregatorExecuteLooksRareV2.test.ts * fix: Variable makerOrdersFromAPI fix error * fix: Set 0 as default value for none in tests * fix: Remove referrerFromAPI declaration in tests --------- Co-authored-by: Hiroshi <108636367+0xhiroshi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.