Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting the output dir is unpredictable #31

Closed
yohanderose opened this issue Oct 2, 2020 · 2 comments
Closed

Overwriting the output dir is unpredictable #31

yohanderose opened this issue Oct 2, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@yohanderose
Copy link
Collaborator

  • On some computers shutil.rmtree takes longer than the sleep time allocated
  • It might be useful to have an 'inplace' option which would allow users to have map2loop output files open in other software while rerunning map2loop
@yohanderose yohanderose added the bug Something isn't working label Oct 2, 2020
@lachlangrose
Copy link
Member

lachlangrose commented Oct 2, 2020 via email

@yohanderose
Copy link
Collaborator Author

Solved by commit b6b6d19. Overwrite flag now accepts a string 'true' for a complete remove, 'false' the default presumed user error and 'in-place' if you don't wish to create a new output file structure but don't mind things overwriting. Complete removal now waits for the existing output directory to be erased before re-creating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants