Removes x86_64 and i386 architectures from plugin frameworks #1489
Conversation
| @@ -16,20 +16,30 @@ function copy_plugins { | |||
| echo Copying device plugin: $plugin to frameworks directory in app | |||
| plugin_path="$(readlink "$f" || echo "$f")" | |||
There was a problem hiding this comment.
The fix is the call to the function I added removeSimArchitectures. That will strip out the architectures for the plugin frameworks.
I also added some comments to help organize the code a bit as I understand it. believe the second half of this function deals with nested frameworks within the plugin.
Side note: I could also call removeSimArchitectures on the frameworks nested in the plugins, but that didn't seem necessary based on testing.
|
I'm somewhat confused as to why this issue doesn't get more visibility. What is it we are doing differently that's not affecting the maintainers? Is this because we are building an Archive and not just using the de-device local debug builds? |
|
@dekimsey I'm not sure if this is still an issue or not as I haven't been building master for a long time. I've only been building dev which doesn't need this fix but master did at one time. You are correct that the original issue would only affect those building Archives which is not a lot of people. |
This is based off the work of PR 1324 which addresses the issue reported in #1117. This PR change targets the master branch though. I also was not able to get PR 1324 to build IPAs without errors so opted for a smaller change in this PR that seems to work well.
The fix here resides in the copy-plugins.sh script, as I believe that is most closely the source of the issue. Extra architectures for frameworks (i386 and x86) are stripped in the copy-frameworks.sh script, via the call to
"${SRCROOT}/bin/carthage" copy-frameworks. That script does not process plugin frameworks though, which are instead copied/installed via the copy-plugins.sh script. This PR will add a stripping mechanism for the plugin script as well for added parity between plugin frameworks vs non-plugin frameworks.In terms of testing, I used Xcode 12.4 and checked the following.
-Build directly to an iPhone 14.4.
-Simulator Builds
-Distribute an ad-hoc IPA.