require OpenJDK version 1.8.0_60 or later to build

[alichnewsky]

tentative fix for #68
Only tested on macOS with java 8.

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[alichnewsky]

could you please advise on the CLA and its process?

I would like on the record that I intend to make this contribution on my own behalf and not that of my employer. (on whose behalf I am pretty sure I do not have authority to agree, and whose approval is not guaranteed and may take a while)

The following makes it ambiguous:

• the wording of the CLA

This is a binding legal agreement on you and any organization you represent. If you are signing this Agreement on behalf of your employer or other organization, you represent and warrant that you have the authority to agree to this Agreement on behalf of the organization.

"You" and "your" means you and any organization on whose behalf you are entering this Agreement.

Agreed and accepted on my behalf and on behalf of my organization

• the fact that nowhere can I state and record a specific organization on whose behalf I would be entering the agreement.
  (see this issue on the CLA assistant repo : lack of support for corporate CLA )
• my github account's affiliation to my present employer's github organization
• the fact that the forked buckaroo repo used to create this PR does not belong to my employer's org
• and the one-click nature of the agreement process

Please advise,
Anthony

[njlr]

Hi Anthony,

Thanks for the PR!

I agree that this is a flaw in our current CLA. Since CLA assistant will not be supporting CCLAs, I will have the wording updated so that you can sign as an individual, not as a member of a corporation.

Regarding the actual PR, I'm surprised that the current LoopPerfect/master does not build. I am also on macOS, with Java version:

java -version
java version "1.8.0_92"
Java(TM) SE Runtime Environment (build 1.8.0_92-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.92-b14, mixed mode)

Would you mind sharing your Java version so that I can investigate?

[njlr]

Just saw the corresponding issue. I will take a look.

[njlr]

Regarding the CLA, would this updated version work for you?

The significant parts:

... This is a binding legal agreement on you or you and the organization you represent...

and:

Which party you are signing on behalf of is determined by the pull request to be merged. If the "base" branch of the pull request belongs to an individual, then the agreement is binding on that individual. If the "base" branch of the pull request belongs to an organization, then the agreement is binding on that organization.

If you are happy with it, I will update CLA Assistant.

[alichnewsky]

The updated CLA, the new version totally works for me.
Thanks a lot !

[alichnewsky]

Since this is indeed an issue with the version of OpenJDK I use, I renamed both the issue and the PR adequately. Please close it without merging.

Please consider updating the CLA nonetheless.

[njlr]

Great, I have updated the CLA.