Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type on --wait-for-ready to int #327

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

Adoni5
Copy link
Contributor

@Adoni5 Adoni5 commented Feb 1, 2024

Adds type to wait-for-ready argument - clearly I hadn't tested it because recently because I get!

Traceback (most recent call last):
  File "/home/adoni5/miniforge3/envs/readfish/bin/readfish", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/adoni5/Projects/readfish/src/readfish/_cli_base.py", line 61, in main
    raise SystemExit(args.func(parser, args, extras))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/adoni5/Projects/readfish/src/readfish/entry_points/targets.py", line 549, in run
    read_until_client = RUClient(
                        ^^^^^^^^^
  File "/home/adoni5/Projects/readfish/src/readfish/_read_until_client.py", line 73, in __init__
    self.wait_for_minknow_folder(self.timeout)
  File "/home/adoni5/Projects/readfish/src/readfish/_read_until_client.py", line 186, in wait_for_minknow_folder
    if seconds_waited > timeout:
       ^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '>' not supported between instances of 'int' and 'str'

This PR fixes that

remove default for `wait_for_minknow_folder` as it was confusing, and the `_cli_args` default is passed through
@Adoni5 Adoni5 merged commit 3fb5df7 into main Feb 2, 2024
9 checks passed
@Adoni5 Adoni5 deleted the hotfix/wait-for-ready branch February 2, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants