Skip to content
This repository has been archived by the owner on Aug 6, 2023. It is now read-only.

Fix return type of ammoOnPylon command #33

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Fix return type of ammoOnPylon command #33

merged 1 commit into from
Sep 29, 2019

Conversation

kymckay
Copy link
Contributor

@kymckay kymckay commented Jan 4, 2018

This command can additionally return a boolean in the case of failure, so it should be considered to return type Anything.

Closes #31

This command can additionally return a boolean in the case of failure,
so it should be considered to return type `Anything`.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.658% when pulling 1029c03 on SilentSpike:fix-ammoOnPylon into 6c2d612 on LordGolias:master.

@dedmen
Copy link

dedmen commented May 8, 2018

Not entirely correct though
https://github.com/intercept/intercept/blob/master/src/client/headers/client/sqf_assignments.hpp#L1260
It returns Number according to engine command definition.
And bool too according to biki https://community.bistudio.com/wiki/ammoOnPylon
Number and Bool is not Anything though

#31 (comment)

I see. But still that is kind of a defect. There are more commands that return multiple types but not Anything.

@kymckay
Copy link
Contributor Author

kymckay commented May 8, 2018

For the purposes of the analyser here any command with multiple return types is considered to return Anything (at least for the time being)

@jonpas
Copy link
Contributor

jonpas commented Sep 11, 2019

Merge?

@LordGolias LordGolias merged commit a171ffe into LordGolias:master Sep 29, 2019
@kymckay kymckay deleted the fix-ammoOnPylon branch September 29, 2019 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter ignores different return types from ammoOnPylon
5 participants