Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(banners-lib): banner generation MVP #19

Draft
wants to merge 20 commits into
base: dev
Choose a base branch
from
Draft

feat(banners-lib): banner generation MVP #19

wants to merge 20 commits into from

Conversation

Guz013
Copy link
Member

@Guz013 Guz013 commented Nov 29, 2023 •
edited
Loading

Create the Banners Library, adding at least the basic features of:

  • Title and Subtitle
  • Icon fetching from Iconify
  • Solid color background

Limitations that should be worked on:

  • Convert text in SVG to paths
  • Check types of the Banner Object
  • Read local SVG files without node:fs
  • Change title position when there's no title

Closes #13

@Guz013 Guz013 linked an issue Nov 29, 2023 that may be closed by this pull request
feat(banner-lib): Banner Object API #13
Open
@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 063e316

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Guz013 Guz013 self-assigned this Nov 29, 2023
@Guz013 Guz013 added the enhancement New feature or request label Nov 29, 2023
@Guz013 Guz013 added this to the Banners library milestone Nov 29, 2023
@Guz013
feat(ci): ✨ 👷 add lint-staged back
94fca1a
@Guz013
feat(banners-lib): ✨ read svg files without node:fs
42f4091 
Added to the SVG converting script a line to create .svg.js files.
These files are normal JS files that exports just a single string,
the SVG file content. This way the library doesn't need a build
step to embed these files and/or node:fs to read them.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This pull request has been deployed to Vercel.

Latest commit: fc3243d
✅ Preview: https://lored-markdown-czwy2yel0-guz013.vercel.app
🔍 Inspect: https://vercel.com/guz013/lored-markdown/72biaWLKS9BrzYEt6UpQJKaGti6h

View Workflow Logs

@Guz013
refactor(text-rendering): ♻️ use embeded fonts
40c89b1 
Removed the text to path conversion, it was
too complicated to align the generated paths
with the dynamic layouts' texts. So embeded
font files using data URIs is being used,
this is experimental and a "quick-fix", because
data URIs could be not compatible and/or work
in some environments and browsers. A comment and/or
issue with more details about this will be created.
@Guz013
chore: 🔧 ignore test files
08b6607
@Guz013
chore: 🔧 upload test.svg, to be tested on github
555b70a 
Uploaded the generated svg to be tested on
github and other environments
@Guz013
Copy link
Member Author

Guz013 commented Jan 17, 2024 •
edited
Loading

test

@Guz013
revert(text-rendering): font embedding
ba31a3b 
time to reinvent the wheel again
@Guz013 Guz013 changed the title feat(banners-lib): banners library and basic banner generation feat(banners-lib): banner generation Jan 17, 2024
@Guz013 Guz013 changed the title feat(banners-lib): banner generation feat(banners-lib): banner generation MVP Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Guz013 Guz013

Labels
deployed enhancement New feature or request
Projects
Lored Markdown roadmap
Status: In Progress
Milestone
Banners library
Development

Successfully merging this pull request may close these issues.

feat(banner-lib): Banner Object API
1 participant
@Guz013