Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files opened with :Files are not showing syntax highlighting and :Buffers is not showing preview correctly #11

Closed
zzzeyez opened this issue Nov 3, 2020 · 9 comments
Labels
bug Something isn't working

Comments

@zzzeyez
Copy link

zzzeyez commented Nov 3, 2020

this is with defaults on macos with the latest version of all components. bat and rg are installed via homebrew

also, on macos, rg spits out errors about accessing stuff in ~/library

10-20-59

10-41-44

it might be worth noting that these issues persist when disabling treesitter and that the bat preview works perfectly for :Files

@LoricAndre
Copy link
Owner

Hi,
firstly the rg error probably isn't coming from my end, it will probably happen too if you try to run rg manually in your home (But I do agree that fzf handles it poorly).
The issue on the first screenshot should be fixed in the last commit.

@zzzeyez
Copy link
Author

zzzeyez commented Nov 3, 2020

i'm on the latest commit and both issues persist

and to be clear: the first screenshot features two separate issues that are both listed in the title

@LoricAndre LoricAndre added the bug Something isn't working label Nov 3, 2020
LoricAndre pushed a commit that referenced this issue Nov 4, 2020
@LoricAndre
Copy link
Owner

Alright, sry for reading the issue too fast. The 2 issues should be fixed now, can you check it out pls ?

@zzzeyez
Copy link
Author

zzzeyez commented Nov 4, 2020

syntax highlighting is now functioning correctly after opening with :Files

:Buffers works correctly now, although it requires confirmation before opening and shows multiple ghost buffers

17-27-41

@zzzeyez
Copy link
Author

zzzeyez commented Nov 4, 2020

actually the :Buffers issue remains as a whole in some instances. it seems the lua files were displaying fine, but these .zsh files are not

@LoricAndre
Copy link
Owner

All right, the ghost buffers are an issue I should have worked on a while ago sry ^^. For the preview of the term buffers, it won't be fixed since they cannot be accessed by any command I could run in the terminal.

@LoricAndre LoricAndre reopened this Nov 4, 2020
@LoricAndre
Copy link
Owner

Sorry I didn't see your last comment, can you pls open a new issue with steps to reproduce and screenshots ?

@zzzeyez
Copy link
Author

zzzeyez commented Nov 4, 2020

here is a video of me using the plugin with defaults

nvim2

everything is newest version. the issues with rg are possibly on my side and you can ignore them. i'll be using fd anyways

@LoricAndre
Copy link
Owner

I see nothing wrong with the plugin here :

  • The messages during fzf loading are due to you not having permission on some files in your home, which seems to be your pwd
  • The display issues on the terminal buffers are normal and cannot be solved as stated earlier
  • The error when exiting the floating window has been reported in issue Opening a file results in error message #13 and is due to an outdated version of neovim.

@zzzeyez zzzeyez closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants