Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECDSA key support #26

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add ECDSA key support #26

merged 3 commits into from
Aug 31, 2023

Conversation

spacetc62
Copy link
Member

No description provided.

@spacetc62 spacetc62 requested a review from eeerin August 31, 2023 16:12
eeerin
eeerin reviewed Aug 31, 2023
View reviewed changes
lib/pem.js
const { promisify } = require('util');

// the getPublicKey method for PEM does not work with ecdsa keys, and does not support passwords
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this link https://github.com/Dexus/pem/blob/master/lib/pem.js#L534

eeerin
eeerin requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@eeerin eeerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good small link to add to the comment.

And see if you can convert to ESM compatible to allow

import { validateSSLCert } from 'ssl-validator';

@eeerin eeerin merged commit 1532c11 into master Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeerin eeerin eeerin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spacetc62 @eeerin