Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OG bug: Bats flicker on death and cause Lara to shoot too rapidly #992

Closed
fare67t opened this issue Sep 19, 2023 · 8 comments · Fixed by #1283
Closed

OG bug: Bats flicker on death and cause Lara to shoot too rapidly #992

fare67t opened this issue Sep 19, 2023 · 8 comments · Fixed by #1283
Assignees
Labels
OG bug A bug in original game
Milestone

Comments

@fare67t
Copy link

fare67t commented Sep 19, 2023

When targeting a freshly killed enemy / already dead one (the very first bats, for example), lara fires her guns WAY too fast for a moment.

Tomb1Main.2023-09-19.19-53-25.-.Trim.mp4
@aredfan
Copy link
Collaborator

aredfan commented Sep 20, 2023

This is an original bug as it's present on TombATI too. Correct me if I'm wrong but I think it's just bats that are affected by this bug.

@Richard-L
Copy link
Collaborator

Good observation @aredfan . Was confused why it's a bat thing, but that would make sense.

@walkawayy walkawayy added the OG bug A bug in original game label Sep 20, 2023
@walkawayy
Copy link
Collaborator

Good observation @aredfan . Was confused why it's a bat thing, but that would make sense.

@aredfan so does this affect bats only? I think I am misunderstanding @Richard-L 's message.
I think it's just bats
Was confused why it's a bat thing, but that would make sense.
What would make sense?

@Richard-L
Copy link
Collaborator

That it seems to only occur with bats :)

@aredfan
Copy link
Collaborator

aredfan commented Sep 23, 2023

@aredfan so does this affect bats only?

I think so because I haven't seen this bug affect enemies other than bats. The faster shooting seem to happen during the bat's drop and bounce animation.

@EternalCosmos92
Copy link

EternalCosmos92 commented Sep 23, 2023

I'd hazard a guess and say it is because Lara many times loses the bats out of her sight because of the dying and falling down animations the bats have. Lara's shooting animations get skipped and start anew when she loses her target and then finds it again and with the bats that happens very often in a short amount of time

@lahm86 lahm86 changed the title Guns shoot way faster than they should when targeting dead things OG bug: Bats flicker on death and cause Lara to shoot too rapidly Apr 8, 2024
@lahm86 lahm86 self-assigned this Apr 8, 2024
@lahm86 lahm86 added this to the 4.0 milestone Apr 8, 2024
lahm86 added a commit to lahm86/TR1X that referenced this issue Apr 8, 2024
This prevents conflicts in setting the bats' Y position during the
death animation, which itself manages Y shift during the bounce.

Resolves LostArtefacts#992.
lahm86 added a commit to lahm86/TR1X that referenced this issue Apr 8, 2024
This prevents conflicts in setting the bats' Y position during the
death animation, which itself manages Y shift during the bounce.

Resolves LostArtefacts#992.
@fawtytoo
Copy link

fawtytoo commented Apr 8, 2024

I'm sure the original title was correct and this was present in the DOS and PS1 versions. Surely this is a mis-observation and not a bug. The description given by @EternalCosmos92 is correct.

Don't get me wrong when I suggest it's not a bug, but it should depend on whether bats really do that when they land on the ground still dying. The fast shooting is just Lara re-targeting. To me, both those things would probably happen in real life.

Don't forget, Lara is never seen reloading her weapons, so there is some scope for things not being like in real life.

lahm86 added a commit that referenced this issue Apr 8, 2024
This prevents conflicts in setting the bats' Y position during the
death animation, which itself manages Y shift during the bounce.

Resolves #992.
@lahm86
Copy link
Collaborator

lahm86 commented Apr 8, 2024

There was a bug whereby the bat's falling speed wasn't being reset when it landed before the bounce. So the animation was shifting its Y position but fall speed was still taken into account when it shouldn't be, hence causing rapid shifts in position and Lara's guns to fire too often/quickly. Details in #1283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants