Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai: make baddies drop ammo if Lara has guns #1001

Merged
merged 2 commits into from
Sep 22, 2023
Merged

ai: make baddies drop ammo if Lara has guns #1001

merged 2 commits into from
Sep 22, 2023

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 22, 2023

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Patch by padoop for the rando so that multiple skaters/cowboys/pierres drop ammo if Lara already has the given weapon. Resolves #1000.

@rr- rr- added the OG bug A bug in original game label Sep 22, 2023
@rr- rr- added this to the 3.0 milestone Sep 22, 2023
Copy link
Collaborator

@walkawayy walkawayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but I know Lahm was already looking into changing how items are dropped.

I think this does cause a minor change if the player gets the magnum secret in Colosseum. Lara will get an extra magnum ammo pickup from before. It makes sense to me to make that change, but I just wanted to bring that up.

Copy link
Collaborator

@lahm86 lahm86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Yes, I think getting the Colosseum secret and then killing Pierre later in Tihocan would give you extra ammo, but we can address that in #967.

@rr- rr- merged commit 6e2d2ef into develop Sep 22, 2023
2 checks passed
@rr- rr- deleted the baddie-pickups branch September 22, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: multiple baddies drop weapons even if Lara already carries them
3 participants