Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flame: tie FX to Lara's room when on fire #1107

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Dec 9, 2023

Resolves #1106.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

This ensures that if Lara enters a different room while on fire, that the flame FX are tied to that room so that they will always be drawn.

This ensures that if Lara enters a different room while on fire, that
the flame FX are tied to that room so that they will always be drawn.

Resolves LostArtefacts#1106.
@lahm86 lahm86 added the OG bug A bug in original game label Dec 9, 2023
@lahm86 lahm86 added this to the 3.1 milestone Dec 9, 2023
@lahm86 lahm86 self-assigned this Dec 9, 2023
@lahm86 lahm86 requested review from rr- and walkawayy December 9, 2023 11:37
Copy link
Collaborator

@walkawayy walkawayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These flames!

@lahm86 lahm86 merged commit 97992d9 into LostArtefacts:develop Dec 9, 2023
1 check passed
@lahm86 lahm86 deleted the issue-1106-track-flame-room branch December 9, 2023 21:22
rr- pushed a commit that referenced this pull request Dec 13, 2023
This ensures that if Lara enters a different room while on fire, that
the flame FX are tied to that room so that they will always be drawn.

Resolves #1106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OG bug: flames are not always drawn when Lara is on fire
3 participants