Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passport: fix new game plus if enable_game_modes set to false #961

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

walkawayy
Copy link
Collaborator

Resolves #960.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Fixed new game plus not working if enable_game_modes was set to false.

@walkawayy walkawayy added the TR1X bug A bug with TR1X label Aug 31, 2023
@walkawayy walkawayy added this to the 2.16 milestone Aug 31, 2023
@walkawayy walkawayy requested review from rr- and lahm86 August 31, 2023 23:11
Copy link
Collaborator

@rr- rr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression; when was this broken?

@walkawayy
Copy link
Collaborator Author

This is a regression; when was this broken?

#494 I believe. 2.8. I'll add to changelog.

@walkawayy walkawayy merged commit c26b5e9 into LostArtefacts:develop Sep 1, 2023
1 check passed
@walkawayy walkawayy deleted the new-game-plus-fix branch September 1, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR1X bug A bug with TR1X
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New game plus doesn't activate if enable_game_modes is false
3 participants