This repository has been archived by the owner on Apr 26, 2022. It is now read-only.
Remove deprecated Variant#currency #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Cherry-picked from Solidus PR 1661. Merged in Solidus 2.1.*
chrisradford
approved these changes
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from Solidus PR 1661. Merged in Solidus 2.1.
Pulling this in for the removal of the
variant.currency=method. This doesn't really work because it changes the currency of thedefault_pricerecord, but this means that the updateddefault_priceobject for the variant is no longer actually the default price because being the default price is dependent on having a currency that matchesSpree::Config.currencyso the in-memorydefault_priceimmediately becomes incorrect.