-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(schema): improve titles, connect values & remove duplications #10
Changes from all commits
17061cc
97242be
ecfe50e
941fcfc
59995b2
bc1c47b
a508973
f923fab
3197116
263a4c5
367e1aa
040b4ad
1bfbe66
0840801
786f10d
0ebae73
de384fd
094ed33
86757d6
55a8f7e
bb704e6
632f4e2
994ce29
2d7bd52
7ac5dce
ec3ca26
9a72368
cf5639b
6cca0f9
90b63a2
b60ab29
6c9aba0
f301d32
9956aad
0aba5a0
db93b0e
abf3680
50eb45e
a066eb0
2fc78a8
19fd976
0b13a8b
86c6403
45bca87
60b1e54
bf67904
a139a05
97118c4
4084bc3
049e266
eff8359
c1127b1
db8a706
174e8ea
b02e671
7295c1f
905e6e9
e88947c
9a5ebe4
2efbfc5
0fe79b1
afe2f2d
52ff01d
2228604
b25381c
a6346da
0730efb
68843b8
389fa2d
5d51e50
062ec97
0d2b5ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"title": "Animated", | ||
"description": "Whether the property is animated", | ||
"type": "object", | ||
"properties": { | ||
"a": { | ||
"$ref": "#/$defs/helpers/int-boolean", | ||
"default": 0 | ||
} | ||
}, | ||
"additionalProperties": false | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"title": "Expression", | ||
"type": "object", | ||
"properties": { | ||
"x": { | ||
"type": "string" | ||
} | ||
}, | ||
"additionalProperties": false | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,17 +7,17 @@ | |
{ | ||
"properties": { | ||
"t": { | ||
"title": "Time", | ||
"title": "Keyframe Time", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure I agree with these, it's describing the keyframe, so why repeat it in the title of the properties? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because it's a generic name I wanted to create a unique title. |
||
"type": "number", | ||
"default": 0 | ||
}, | ||
"h": { | ||
"title": "Hold", | ||
"title": "Keyframe Hold", | ||
"$ref": "#/$defs/helpers/int-boolean", | ||
"default": 0 | ||
}, | ||
"s": { | ||
"title": "Value", | ||
"title": "Keyframe Value", | ||
"description": "Value at this keyframe. Note the if the property is a scalar, keyframe values are still represented as arrays", | ||
"type": "array", | ||
"items": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,67 +5,67 @@ | |
"description": "", | ||
"oneOf": [ | ||
{ | ||
"title": "Normal", | ||
"title": "Blend Mode Normal", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I definitely don't like repeating the enum name in its values to be honest There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, it's not ideal, but then can you suggest a name? so we could avoid the generic names which may be created in other props There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What problem would it cause if "Normal" is used elsewhere too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. answered in the comment below |
||
"const": 0 | ||
}, | ||
{ | ||
"title": "Multiply", | ||
"title": "Blend Mode Multiply", | ||
"const": 1 | ||
}, | ||
{ | ||
"title": "Screen", | ||
"title": "Blend Mode Screen", | ||
"const": 2 | ||
}, | ||
{ | ||
"title": "Overlay", | ||
"title": "Blend Mode Overlay", | ||
"const": 3 | ||
}, | ||
{ | ||
"title": "Darken", | ||
"title": "Blend Mode Darken", | ||
"const": 4 | ||
}, | ||
{ | ||
"title": "Lighten", | ||
"title": "Blend Mode Lighten", | ||
"const": 5 | ||
}, | ||
{ | ||
"title": "Color Dodge", | ||
"title": "Blend Mode Color Dodge", | ||
"const": 6 | ||
}, | ||
{ | ||
"title": "Color Burn", | ||
"title": "Blend Mode Color Burn", | ||
"const": 7 | ||
}, | ||
{ | ||
"title": "Hard Light", | ||
"title": "Blend Mode Hard Light", | ||
"const": 8 | ||
}, | ||
{ | ||
"title": "Soft Light", | ||
"title": "Blend Mode Soft Light", | ||
"const": 9 | ||
}, | ||
{ | ||
"title": "Difference", | ||
"title": "Blend Mode Difference", | ||
"const": 10 | ||
}, | ||
{ | ||
"title": "Exclusion", | ||
"title": "Blend Mode Exclusion", | ||
"const": 11 | ||
}, | ||
{ | ||
"title": "Hue", | ||
"title": "Blend Mode Hue", | ||
"const": 12 | ||
}, | ||
{ | ||
"title": "Saturation", | ||
"title": "Blend Mode Saturation", | ||
"const": 13 | ||
}, | ||
{ | ||
"title": "Color", | ||
"title": "Blend Mode Color", | ||
"const": 14 | ||
}, | ||
{ | ||
"title": "Luminosity", | ||
"title": "Blend Mode Luminosity", | ||
"const": 15 | ||
} | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't
additionalProperties
cause issues?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, to be safe and avoid unexpected problems let me remove them