Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 馃悰 React 18 strict mode double animation #94

Merged
merged 3 commits into from
May 13, 2022
Merged

fix: 馃悰 React 18 strict mode double animation #94

merged 3 commits into from
May 13, 2022

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented May 13, 2022 •
edited
Loading

Description

  • Introduced unmounted flag to avoid creating animation when the <Player /> gets mounted, unmounted and mounted back in the strict mode.
  • Added the animation asset to the react app assets to avoid flaky and speed up cypress tests
  • Introduced React 18 to the react app under cypress

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

closes #92

@theashraf theashraf marked this pull request as ready for review May 13, 2022 06:48
@theashraf theashraf self-assigned this May 13, 2022
@theashraf theashraf merged commit 32e0728 into LottieFiles:develop May 13, 2022
theashraf added a commit that referenced this pull request May 13, 2022
@theashraf @samuelOsborne
fix: 馃悰 React 18 strict mode double animation (#94) (#95)
a3b94d0 
* fix: 馃悰 React 18 strict mode double animation

* chore: 馃 changeset

Co-authored-by: SamuelOsborne <samu.osborne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelOsborne samuelOsborne samuelOsborne approved these changes

Assignees

@theashraf theashraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theashraf @samuelOsborne