Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase #97

Closed
ghost opened this issue Sep 19, 2015 · 9 comments
Closed

Showcase #97

ghost opened this issue Sep 19, 2015 · 9 comments

Comments

@ghost
Copy link

ghost commented Sep 19, 2015

I want to add my blog to Showcase:

BTW,there's a bug in the post-action bar.For example,this article has a toc,and the button on the left should link to #table-of-contents,but in fact it link to # just like it doesn't have a toc.
Sorry for my poor coding skill,I can't find what's wrong in the source code.Hope solving soon.

@chawyehsu
Copy link

For showcase, you can open a new pull request. And I recommend a new branch (e.g. branch showcase) should be created to receive all those showcase pull requests, instead of merging them into the source code branch (master / dev).

For that bug, yes, I think it's a bug, the same issue can be found on the official demo page. But I don't know why. layout/_partial/post/actions.ejs#L55

cc @LouisBarranqueiro

@LouisBarranqueiro
Copy link
Owner

Thanks you @Imyssed. It's a bug, could you open an issue for this. I have already fix this one but I want to link the commit with the issue (bug) please. :)

About your theme, I don't know if the showcase is the right place for your work. I think, i'm gonna create a wiki to present customized version (css and js mainly) and also special version of Tranquilpeak like yours. :)

@LouisBarranqueiro
Copy link
Owner

@Imyssed Please respect terms of the GNU General Public License v3.0 :) There is currently no license in your project and my name is not mentioned.

@ghost
Copy link
Author

ghost commented Sep 22, 2015

Oh,I've forgotten it:joy:I'll add it soon.
BTW,there's a bug in archives page.The disply of date format and placeholder in the search form don't follow the language settings.
I'm not convenient to pull request,but I fixed it here.
https://github.com/Imyssed/tranquilpeak-hexo-theme/commit/6f78d46de9f53580ad525917a3fc4079312a8182

@LouisBarranqueiro
Copy link
Owner

This bug had been already fixed : #92
To do it simple, keep package.json file which contains authors and licence :)

@LouisBarranqueiro
Copy link
Owner

Open an issue about bug of table of content button please :)

@chawyehsu
Copy link

@LouisBarranqueiro or your can open by yourself. 😓

@LouisBarranqueiro
Copy link
Owner

Oh, he discover the bug, so he can create the issue :D

@LouisBarranqueiro
Copy link
Owner

But nevermind, i reference this issue on the commit :D.

@ghost ghost closed this as completed Sep 23, 2015
@ghost ghost changed the title Chinese i18n Showcase Jan 9, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants