Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make actions pure #35

Closed

Conversation

bobbydixit
Copy link

@bobbydixit bobbydixit commented Apr 15, 2017

Connects to

Changes proposed (features or fixes)

Make actions pure to remove dependency over thunk middleware

How to test

Checklist

  • Don't forget to update README or API documentation if it's necessary
  • Check code status with npm run lint
  • Run tests with npm run test:all
  • Launch demo with npm start to check the result in the browser. Check it on all possible browsers that you have and write them in the PR.
    • Chrome
    • Safari
    • Firefox
    • IE 10+
    • Edge
    • Opera

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 93.443% when pulling bc7823d on bobbydixit:make_actions_pure into 1793ead on LouisBarranqueiro:master.

@LouisBarranqueiro
Copy link
Owner

Hey @bobbydixit, thank you for your contribution but I don't really like the changes around image fetching, and the new logic added on the react part. Less logic in the component, the better. Yes, pure actions would be cool, but this implementation looks like very complicated. Let's find another way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants