Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate GitHub actions and build system updates #25

Merged
merged 26 commits into from
Sep 1, 2022
Merged

Integrate GitHub actions and build system updates #25

merged 26 commits into from
Sep 1, 2022

Conversation

ahoarau
Copy link
Collaborator

@ahoarau ahoarau commented Aug 24, 2022 •
edited

  • remove doxygen
  • Remove travis and appveyor
  • Integrate Github actions
  • Make fetchcontent possible
  • Update readme

Open questions:

  • Is coverage used ?
  • Is Warnings.cmake necessary ?

@ahoarau ahoarau added the enhancement New feature or request label Aug 24, 2022
@LouisCharlesC
Copy link
Owner 

remove doxygen

Whatever.

Remove travis and appveyor
Integrate Github actions

Very cool.

Switch testing to catch2 via fetchcontent

But I like doctest :(

Open questions:

Is coverage used ?

No idea. Maybe it was once, I absolutely forgot.

Is Warnings.cmake necessary ?

I guess some people compile with warnings as errors, if an error stops their compilation because of a warning in safe, it's pretty bad, no ?

LouisCharlesC
LouisCharlesC reviewed Aug 24, 2022
View reviewed changes
.github/workflows/cmake.yml Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
tests/test_readme.cpp Outdated Show resolved Hide resolved
@ahoarau
Copy link
Collaborator Author

ahoarau commented Aug 25, 2022

No idea. Maybe it was once, I absolutely forgot.

To be removed then

Is Warnings.cmake necessary ?

I guess some people compile with warnings as errors, if an error stops their compilation because of a warning in safe, it's pretty bad, no ?

It's just for the tests that you enabled them. + I have no warnings on MSVC

@LouisCharlesC
Copy link
Owner

LouisCharlesC commented Aug 26, 2022 •
edited

It's just for the tests that you enabled them. + I have no warnings on MSVC

Yeah, when I compile my tests, I should see any warning pop up as an error, which ensures no one will ever have a warning using safe. It's only on in the tests so it's not enforced to users. It's just extra burden for me and it's the reason you don't see any warnings in MSVC!

@ahoarau
Copy link
Collaborator Author

ahoarau commented Aug 27, 2022

Ok everything is ready !

  • github actions
  • Local project with tests
  • testing the install space
  • testing on multiples OS
  • testing on different c++ standards

@LouisCharlesC
Copy link
Owner

I updated the badge in the readme.
Is this part of the readme alright ?

mkdir build
cd build
cmake ..
sudo cmake --build . --target install

@LouisCharlesC
Copy link
Owner

It would be neat to have a coverage badge ;)

LouisCharlesC
LouisCharlesC reviewed Aug 28, 2022
View reviewed changes
CMakeLists.txt
@@ -2,17 +2,23 @@ cmake_minimum_required(VERSION 3.9.2)

cmake_policy(SET CMP0048 NEW)
project(safe VERSION 1.0.0 LANGUAGES CXX)
option(BUILD_TESTING "Build tests" ON)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this wanted ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's just to make it explicit.

The equivalent of the option + enable_testing is to simply include(CTest)

@ahoarau
Copy link
Collaborator Author

ahoarau commented Aug 28, 2022

It would be neat to have a coverage badge ;)

Don't know how to do that. We need to update the readme as well for the CI badges

@ahoarau
Copy link
Collaborator Author

ahoarau commented Aug 28, 2022

I updated the badge in the readme.
Is this part of the readme alright ?

mkdir build
cd build
cmake ..
sudo cmake --build . --target install

I'll suggest something

@ahoarau ahoarau changed the title Integrate GitHub actions and catch2 Integrate GitHub actions Aug 29, 2022
@ahoarau ahoarau changed the title Integrate GitHub actions Integrate GitHub actions and build system updates Aug 29, 2022
@ahoarau ahoarau merged commit cc0530a into master Sep 1, 2022
@ahoarau ahoarau deleted the integrate-github-actions branch September 1, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisCharlesC LouisCharlesC LouisCharlesC approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahoarau @LouisCharlesC