Merge pull request #56 from LoveCommunity/refactor/rename-data-to-state

rename `data` to `state` when using `States`
LoveCommunity · Jun 28, 2022 · 0e25dc5 · 0e25dc5
2 parents a4de72c + 5aaecc7
commit 0e25dc5
Show file tree

Hide file tree

Showing 17 changed files with 41 additions and 41 deletions.
diff --git a/lib/src/observables/states/states_first.dart b/lib/src/observables/states/states_first.dart
@@ -8,9 +8,9 @@ import 'states.dart';
 @internal
 T statesFirst<T>(States<T> states) {
   Value<T>? result;
-  states.observe((data) {
+  states.observe((state) {
     if (result == null) {
-      result = Value(data);
+      result = Value(state);
     }
   })
   .dispose();

diff --git a/test/observables/observables/observable_cast_test.dart b/test/observables/observables/observable_cast_test.dart
@@ -39,7 +39,7 @@ void main() {
 
     expect(
       () {
-        cast.observe((data) {});
+        cast.observe((_) {});
       },
       throwsA(
         isA<TypeError>()

diff --git a/test/observables/observables/observable_combine_test.g.dart b/test/observables/observables/observable_combine_test.g.dart
diff --git a/test/observables/observables/observable_default_constructor_test.dart b/test/observables/observables/observable_default_constructor_test.dart
@@ -62,7 +62,7 @@ void main() {
       });
     });
 
-    final observation = observable.observe((data) {});
+    final observation = observable.observe((_) {});
 
     expect(invoked, 0);
     observation.dispose();

diff --git a/test/observables/observables/observable_multicast_replay_test.dart b/test/observables/observables/observable_multicast_replay_test.dart
@@ -17,9 +17,9 @@ void main() {
     final multicastReplay = observable.multicastReplay(3);
 
     expect(invokes, 0);
-    final observation1 = multicastReplay.observe((data) {});
+    final observation1 = multicastReplay.observe((_) {});
     expect(invokes, 1);
-    final observation2 = multicastReplay.observe((data) {});
+    final observation2 = multicastReplay.observe((_) {});
     expect(invokes, 1);
 
     observation1.dispose();
@@ -39,8 +39,8 @@ void main() {
 
     final multicastReplay = observable.multicastReplay(3);
 
-    final observation1 = multicastReplay.observe((data) {});
-    final observation2 = multicastReplay.observe((data) {});
+    final observation1 = multicastReplay.observe((_) {});
+    final observation2 = multicastReplay.observe((_) {});
 
     expect(invokes, 0);
     observation1.dispose();
@@ -103,7 +103,7 @@ void main() {
       multicastReplay,
     );
 
-    final observation = multicastReplay.observe((data) {});
+    final observation = multicastReplay.observe((_) {});
 
     expect(tester.recorded, []);
     tester.startObserve();

diff --git a/test/observables/observables/observable_multicast_test.dart b/test/observables/observables/observable_multicast_test.dart
@@ -17,9 +17,9 @@ void main() {
     final multicast = observable.multicast();
 
     expect(invokes, 0);
-    final observation1 = multicast.observe((data) {});
+    final observation1 = multicast.observe((_) {});
     expect(invokes, 1);
-    final observation2 = multicast.observe((data) {});
+    final observation2 = multicast.observe((_) {});
     expect(invokes, 1);
 
     observation1.dispose();
@@ -39,8 +39,8 @@ void main() {
 
     final multicast = observable.multicast();
 
-    final observation1 = multicast.observe((data) {});
-    final observation2 = multicast.observe((data) {});
+    final observation1 = multicast.observe((_) {});
+    final observation2 = multicast.observe((_) {});
 
     expect(invokes, 0);
     observation1.dispose();
@@ -106,10 +106,10 @@ void main() {
       );
 
     expect(invokes, 0);
-    final observation1 = multicast.observe((data) {});
+    final observation1 = multicast.observe((_) {});
     expect(invokes, 1);
     expect(subject.observeInvokes, 1);
-    final observation2 = multicast.observe((data) {});
+    final observation2 = multicast.observe((_) {});
     expect(invokes, 1);
     expect(subject.observeInvokes, 2);
 
@@ -138,8 +138,8 @@ void main() {
         },
       );
 
-    final observation1 = multicast.observe((data) {});
-    final observation2 = multicast.observe((data) {});
+    final observation1 = multicast.observe((_) {});
+    final observation2 = multicast.observe((_) {});
 
     expect(invokes, 0);
     expect(subject.observationDisposeInvokes, 0);
@@ -168,8 +168,8 @@ void main() {
         },
       );
 
-    final observation1 = multicast.observe((data) {});
-    final observation2 = multicast.observe((data) {});
+    final observation1 = multicast.observe((_) {});
+    final observation2 = multicast.observe((_) {});
 
     expect(subject.disposeInvokes, 0);
     observation1.dispose();
@@ -196,7 +196,7 @@ void main() {
         },
       );
 
-    final observation = multicast.observe((data) {});
+    final observation = multicast.observe((_) {});
 
     expect(subject.recorded, []);
     await Future(() {});

diff --git a/test/observables/observables/proxy_observable_test.dart b/test/observables/observables/proxy_observable_test.dart
@@ -42,7 +42,7 @@ void main() {
       proxy: observable,
     );
 
-    final observation = proxyObservable.observe((data) {});
+    final observation = proxyObservable.observe((_) {});
 
     expect(invokes, 0);
     observation.dispose();

diff --git a/test/observables/states/states_cache_test.dart b/test/observables/states/states_cache_test.dart
@@ -19,9 +19,9 @@ void main() {
     final cache = states.cache();
 
     expect(invokes, 0);
-    final observation1 = cache.observe((data) {});
+    final observation1 = cache.observe((_) {});
     expect(invokes, 1);
-    final observation2 = cache.observe((data) {});
+    final observation2 = cache.observe((_) {});
     expect(invokes, 1);
 
     observation1.dispose();
@@ -42,8 +42,8 @@ void main() {
 
     final cache = states.cache();
 
-    final observation1 = cache.observe((data) {});
-    final observation2 = cache.observe((data) {});
+    final observation1 = cache.observe((_) {});
+    final observation2 = cache.observe((_) {});
 
     expect(invokes, 0);
     observation1.dispose();
@@ -111,7 +111,7 @@ void main() {
       cache,
     );
 
-    final observation  = cache.observe((data) {});
+    final observation  = cache.observe((_) {});
 
     expect(tester.recorded, []);
     tester.startObserve();

diff --git a/test/observables/states/states_cast_test.dart b/test/observables/states/states_cast_test.dart
@@ -41,7 +41,7 @@ void main() {
 
     expect(
       () {
-        cast.observe((data) {});
+        cast.observe((_) {});
       },
       throwsA(
         isA<TypeError>()

diff --git a/test/observables/states/states_combine_test.g.dart b/test/observables/states/states_combine_test.g.dart
diff --git a/test/observables/states/states_default_constructor_test.dart b/test/observables/states/states_default_constructor_test.dart
@@ -38,7 +38,7 @@ void main() {
       });
     });
 
-    final observation = states.observe((data) {});
+    final observation = states.observe((_) {});
 
     expect(invokes, 0);
     observation.dispose();

diff --git a/test/observables/states/states_from_test.dart b/test/observables/states/states_from_test.dart
@@ -40,7 +40,7 @@ void main() {
     final states = States.from(observable);
 
     expect(invokes, 0);
-    final observation = states.observe((data) {});
+    final observation = states.observe((_) {});
     expect(invokes, 1);
 
     observation.dispose();
@@ -58,7 +58,7 @@ void main() {
 
     final states = States.from(observable);
 
-    final observation = states.observe((data) {});
+    final observation = states.observe((_) {});
 
     expect(invokes, 0);
     observation.dispose();

diff --git a/test/observables/states/states_map_test.dart b/test/observables/states/states_map_test.dart
@@ -16,7 +16,7 @@ void main() {
     });
 
     final map = states
-      .map<int>((data) => data.length);
+      .map<int>((state) => state.length);
 
     final tester = StatesTester(
       map,

diff --git a/test/observables/subjects/publish_subject_test.dart b/test/observables/subjects/publish_subject_test.dart
@@ -141,7 +141,7 @@ void main() {
 
     expect(
       () {
-        subject.observe((data) {});
+        subject.observe((_) {});
       },
       throwsA(
         isA<StateError>()

diff --git a/test/observables/subjects/replay_subject_test.dart b/test/observables/subjects/replay_subject_test.dart
@@ -193,7 +193,7 @@ void main() {
 
     expect(
       () {
-        subject.observe((data) {});
+        subject.observe((_) {});
       },
       throwsA(
         isA<StateError>()

diff --git a/test/observables/subjects/value_subject_test.dart b/test/observables/subjects/value_subject_test.dart
@@ -184,7 +184,7 @@ void main() {
 
     expect(
       () {
-        subject.observe((data) {});
+        subject.observe((_) {});
       },
       throwsA(
         isA<StateError>()

diff --git a/test/test_gen/combine_test/test_cases/test_dispose_observation.dart b/test/test_gen/combine_test/test_cases/test_dispose_observation.dart
@@ -37,7 +37,7 @@ String _observable(bool isLast, int n) {
 
 String _startObserve() {
   return '''
-    final observation = combine.observe((data) {});
+    final observation = combine.observe((_) {});
   ''';
 }