Merge pull request #76 from LoveCommunity/refactor/configurable-combine

make `ConfigurableCombine` abstract class
LoveCommunity · Jul 14, 2022 · 758cca3 · 758cca3
2 parents f2b3346 + 814f7b0
commit 758cca3
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/lib/src/scopes/configurables/configurable.dart b/lib/src/scopes/configurables/configurable.dart
@@ -12,6 +12,6 @@ abstract class Configurable {
   const factory Configurable(ScopeConfigure configure) = ConfigurableFunction;
   const factory Configurable.combine({
     required List<Configurable> children,
-  }) = ConfigurableCombine;
+  }) = ConfigurableCombine.impl;
 }
 
diff --git a/lib/src/scopes/configurables/configurable_combine.dart b/lib/src/scopes/configurables/configurable_combine.dart
@@ -6,17 +6,34 @@ import '../scopes/configurable_scope.dart';
 import '../shared/build_scope.dart';
 import 'configurable.dart';
 
-@internal
-class ConfigurableCombine implements Configurable {
+abstract class ConfigurableCombine implements Configurable {
 
-  const ConfigurableCombine({
+  const ConfigurableCombine();
+
+  @internal
+  const factory ConfigurableCombine.impl({
+    required List<Configurable> children,
+  }) = _ConfigurableCombineImpl;
+
+  List<Configurable> combine();
+
+  @override
+  FutureOr<void> configure(ConfigurableScope scope) {
+    final configure = combine();
+    return configureScope(configure, scope);
+  }
+}
+
+class _ConfigurableCombineImpl extends ConfigurableCombine {
+
+  const _ConfigurableCombineImpl ({
     required List<Configurable> children,
   }): _children = children;
 
   final List<Configurable> _children;
 
   @override
-  FutureOr<void> configure(ConfigurableScope scope) {
-    return configureScope(_children, scope);
+  List<Configurable> combine() {
+    return _children;
   }
 }
diff --git a/lib/src/scopes/scopes.dart b/lib/src/scopes/scopes.dart
@@ -1,6 +1,7 @@
 
 export 'configurables/async_final.dart';
 export 'configurables/configurable.dart';
+export 'configurables/configurable_combine.dart';
 export 'configurables/final.dart';
 export 'errors/scope_value_not_exposed_error.dart';
 export 'scope_methods/disposable_sink.dart';