Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - rename ValueDispose to DisposeValue #133

Merged
merged 1 commit into from
Oct 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/dart_scope.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ export 'src/dart_scope/dart_scope.dart'
ScopePush,
ConfigurableScope,
Scope,
ValueDispose,
DisposeValue,
ValueExpose,
Equal;
4 changes: 2 additions & 2 deletions lib/src/dart_scope/configurables/async_final.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class AsyncFinal<T> implements Configurable {
Object? name,
required Equal<Future<T>> equal,
ValueExpose<T>? expose,
ValueDispose<T>? dispose,
DisposeValue<T>? dispose,
}): _name = name,
_equal = equal,
_expose = expose,
Expand All @@ -22,7 +22,7 @@ class AsyncFinal<T> implements Configurable {
final Object? _name;
final Equal<Future<T>> _equal;
final ValueExpose<T>? _expose;
final ValueDispose<T>? _dispose;
final DisposeValue<T>? _dispose;

@override
FutureOr<void> configure(ConfigurableScope scope) async {
Expand Down
4 changes: 2 additions & 2 deletions lib/src/dart_scope/configurables/final.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Final<T> implements Configurable {
Object? name,
required Equal<T> equal,
ValueExpose<T>? expose,
ValueDispose<T>? dispose,
DisposeValue<T>? dispose,
bool lazy = true,
}): _name = name,
_equal = equal,
Expand All @@ -24,7 +24,7 @@ class Final<T> implements Configurable {
final Object? _name;
final Equal<T> _equal;
final ValueExpose<T>? _expose;
final ValueDispose<T>? _dispose;
final DisposeValue<T>? _dispose;
final bool _lazy;

@override
Expand Down
2 changes: 1 addition & 1 deletion lib/src/dart_scope/configurables/final_states.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ ValueExpose<StatesActivated<T>> _superExpose<T>(Object? name) {
};
}

ValueDispose<StatesActivated<T>> _superDispose<T>() {
DisposeValue<StatesActivated<T>> _superDispose<T>() {
return (activated) => activated.dispose();
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class FinalStatesConvertible<T, E> implements Configurable {
Object? statesName,
required States<E> Function(T it) statesEqual,
StatesConvertibleExpose<T, E>? expose,
ValueDispose<T>? dispose,
DisposeValue<T>? dispose,
bool lazy = true,
}): _name = name,
_equal = equal,
Expand All @@ -39,7 +39,7 @@ class FinalStatesConvertible<T, E> implements Configurable {
final Object? _statesName;
final States<E> Function(T it) _statesEqual;
final StatesConvertibleExpose<T, E>? _expose;
final ValueDispose<T>? _dispose;
final DisposeValue<T>? _dispose;
final bool _lazy;

@override
Expand Down
2 changes: 1 addition & 1 deletion lib/src/dart_scope/dart_scope.dart
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ export 'scopes/scope.dart'
Scope;
export 'shared/typedefs.dart'
show
ValueDispose,
DisposeValue,
ValueExpose,
Equal;
2 changes: 1 addition & 1 deletion lib/src/dart_scope/shared/expose_in_scope.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ void exposeInScope<T>({
required Object? name,
required Getter<T> getValue,
required ValueExpose<T>? expose,
required ValueDispose<T>? dispose,
required DisposeValue<T>? dispose,
}) {

final valueExpose = expose ?? defaultExpose(name);
Expand Down
2 changes: 1 addition & 1 deletion lib/src/dart_scope/shared/typedefs.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ import 'package:typedef_foundation/typedef_foundation.dart';
import '../scope_methods/scope_expose.dart';
import '../scope_methods/scope_get.dart';

typedef ValueDispose<T> = void Function(T);
typedef DisposeValue<T> = void Function(T);
typedef ValueExpose<T> = void Function(ScopeExpose scope, Getter<T> getValue);
typedef Equal<T> = T Function(ScopeGet scope);