Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - reimplements ObservableCreate using Observation #164

Merged
merged 1 commit into from
Jan 31, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
57 changes: 41 additions & 16 deletions lib/src/dart_observable/observables/observable_create.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import 'package:meta/meta.dart';
import 'package:disposal/disposal.dart';

import 'observable.dart';
import 'observation.dart';
import '../observers/observer.dart';

@internal
Expand All @@ -14,21 +15,45 @@ class ObservableCreate<T> implements Observable<T> {

@override
Disposable observe(OnData<T> onData) {
bool disposed = false;

final observation = _observe((data) {
if (disposed) {
return;
}
onData(data);
});

return Disposable(() {
if (disposed) {
return;
}
disposed = true;
observation.dispose();
});
return _Observation<T>(
observe: _observe,
emit: onData,
);
}
}

class _Observation<T> extends Observation<T> implements Observer<T> {

_Observation({
required Observe<T> observe,
required OnData<T> emit,
}): _observe = observe,
super(emit: emit);

final Observe<T> _observe;

bool _disposed = false;
late final Disposable _sourceObservation;

@override
void init() {
_sourceObservation = _observe(onData);
}

@override
void onData(T data) {
if (_disposed) {
return;
}
emit(data);
}

@override
void dispose() {
if (_disposed) {
return;
}
_disposed = true;
_sourceObservation.dispose();
}
}