Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback functions #104

Merged
merged 12 commits into from
Jul 17, 2017
Merged

Add callback functions #104

merged 12 commits into from
Jul 17, 2017

Conversation

moteus
Copy link
Member

@moteus moteus commented Jul 12, 2017

Close #103

@moteus moteus mentioned this pull request Jul 12, 2017
Closed
5 tasks
@coveralls
Copy link

coveralls commented Jul 12, 2017 •
edited

Coverage Status

Coverage decreased (-1.8%) to 59.481% when pulling a2cacb8 on moteus:master into e0a47d5 on Lua-cURL:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.622% when pulling d87d030 on moteus:master into e0a47d5 on Lua-cURL:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.622% when pulling d87d030 on moteus:master into e0a47d5 on Lua-cURL:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.622% when pulling d87d030 on moteus:master into e0a47d5 on Lua-cURL:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.622% when pulling d87d030 on moteus:master into e0a47d5 on Lua-cURL:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.622% when pulling d87d030 on moteus:master into e0a47d5 on Lua-cURL:master.

@coveralls
Copy link

coveralls commented Jul 12, 2017 •
edited

Coverage Status

Coverage decreased (-2.8%) to 58.521% when pulling bb5fa08 on moteus:master into e0a47d5 on Lua-cURL:master.

moteus
moteus commented Jul 12, 2017
View reviewed changes
src/lceasy.c Outdated

static int lcurl_easy_set_CHUNK_END_FUNCTION(lua_State *L){
lcurl_easy_t *p = lcurl_geteasy(L);
return lcurl_easy_set_callback(L, p, &p->chunk_bgn,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix callback pointer

moteus
moteus commented Jul 12, 2017
View reviewed changes
src/lceasy.c Outdated
OPT_ENTRY(INFO_SSL_DATA_OUT )
OPT_ENTRY(INFO_SSL_DATA_IN )
#undef OPT_ENTRY

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add curl file types constants

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage decreased (-2.8%) to 58.521% when pulling fe202ed on moteus:master into e0a47d5 on Lua-cURL:master.

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage decreased (-2.8%) to 58.521% when pulling e2d5cfc on moteus:master into e0a47d5 on Lua-cURL:master.

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage decreased (-2.8%) to 58.521% when pulling bd76cfc on moteus:master into e0a47d5 on Lua-cURL:master.

data-man
data-man reviewed Jul 13, 2017
View reviewed changes
src/lceasy.c Outdated
lcurl_easy_t *p = lcurl_geteasy(L);
return lcurl_easy_set_callback(L, p, &p->chunk_end,
CURLOPT_CHUNK_END_FUNCTION, CURLOPT_CHUNK_DATA,
"chunk_end", lcurl_chunk_bgn_callback
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe lcurl_chunk_end_callback?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really need tests :)
But this is FTP only functions and I do not know how to install ftp on travis without sudo.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for the Windows the library not compiled without the Lake. :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There MSVC project or luarocks make rockspecs/lua-curl-scm-0.rockspec

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage decreased (-3.2%) to 58.099% when pulling 34fc5fe on moteus:master into e0a47d5 on Lua-cURL:master.

@moteus moteus merged commit 316cf79 into Lua-cURL:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@data-man data-man data-man left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moteus @coveralls @data-man