Misleading assertion in asm_fload() for mips.

[Buristan]

This is about the following assertion:

LuaJIT/src/lj_asm_mips.h

Line 1341 in 8635cba

lj_assertA(!irt_isfp(ir->t), "bad FP FLOAD");

After 786dbb2 it is possible to use FLOAD for fields load from GG_State.
In particular, it is used for load of LJ_KSIMD_ABS (num FLOAD nil #404). This IR has number type, so this leads to the assertion failure (-O0 is used for more simple repro):

LUA_PATH="src/?.lua;;" LD_LIBRARY_PATH="/usr/lib/gcc/mips64el-unknown-linux-gnu/13/" qemu-mips64el -L /usr/mips64el-unknown-linux-gnu/ src/luajit -jdump=i -Ohotloop=1 -O0 -e '
local t = {nil, nil,nil,nil}
for i = 1, 4 do
  t[i] = math.abs(i - 10)
end
for i = 1, 4 do
  print(t[i])
end
'
---- TRACE 1 start (command line):3
LuaJIT ASSERT lj_asm_mips.h:1341: asm_fload: bad FP FLOAD
Aborted (core dumped)

Should the assertion be inside else branch too, like the following?

diff --git a/src/lj_asm_mips.h b/src/lj_asm_mips.h
index e9cce916..8824081e 100644
--- a/src/lj_asm_mips.h
+++ b/src/lj_asm_mips.h
@@ -1337,8 +1337,8 @@ static void asm_fload(ASMState *as, IRIns *ir)
       }
     }
     ofs = field_ofs[ir->op2];
+    lj_assertA(!irt_isfp(ir->t), "bad FP FLOAD");
   }
-  lj_assertA(!irt_isfp(ir->t), "bad FP FLOAD");
   emit_tsi(as, mi, dest, idx, ofs);
 }

[MikePall]

Fixed. Thanks!