Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace wiki references #2255

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

carsakiller
Copy link
Collaborator

@carsakiller carsakiller commented Aug 11, 2023

Replaces references to the old wiki with references to the new wiki.

Not quite sure what to do for the below instances, as they haven't existed in a long while, as far as I can tell:

* `NEW` offline diagnostic, [read more](https://github.com/LuaLS/lua-language-server/wiki/Offline-Diagnostic)

[read more](https://github.com/LuaLS/lua-language-server/wiki/IntelliSense-optional-features)

'Please read [wiki](https://github.com/LuaLS/lua-language-server/wiki/IntelliSense-optional-features) to learn more.'
config.IntelliSense.traceReturn =
'Please read [wiki](https://github.com/LuaLS/lua-language-server/wiki/IntelliSense-optional-features) to learn more.'
config.IntelliSense.traceBeSetted =
'Please read [wiki](https://github.com/LuaLS/lua-language-server/wiki/IntelliSense-optional-features) to learn more.'
config.IntelliSense.traceFieldInject =
'Please read [wiki](https://github.com/LuaLS/lua-language-server/wiki/IntelliSense-optional-features) to learn more.'

@carsakiller carsakiller added the documentation Has to do with documentation either in the wiki or in the repo label Aug 11, 2023
@carsakiller carsakiller self-assigned this Aug 11, 2023
@sumneko
Copy link
Collaborator

sumneko commented Aug 11, 2023

You may delete them

@carsakiller
Copy link
Collaborator Author

Removed the old intellisense stuff. I think the changelog stuff should stay if it is just old features. I was mainly wondering if "offline diagnostic" is the current "diagnosis report".

@sumneko
Copy link
Collaborator

sumneko commented Aug 11, 2023

I was mainly wondering if "offline diagnostic" is the current "diagnosis report".

Yes

@carsakiller
Copy link
Collaborator Author

Okay, should be all good then!

@sumneko sumneko merged commit dab3ea3 into LuaLS:master Aug 11, 2023
7 checks passed
@carsakiller carsakiller deleted the wiki-migration branch August 11, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Has to do with documentation either in the wiki or in the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants