Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.3.0] Shelf no longer has icon_type, breaks most of getLibrary #637

Open
4 tasks done
iBicha opened this issue Apr 14, 2024 · 3 comments
Open
4 tasks done

[9.3.0] Shelf no longer has icon_type, breaks most of getLibrary #637

iBicha opened this issue Apr 14, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@iBicha
Copy link
Contributor

iBicha commented Apr 14, 2024

Steps to reproduce

  1. Login
  2. getLibrary()
  3. Try to access any section (library.liked_videos, library.playlists_section, etc)

All of the sections return undefined, because the sections don't have the icon_type property anymore, which is being used to identify the section

Failure Logs

N/A

Expected behavior

Sections in Library work as expected

Current behavior

All sections has no types
sections

Version

Default

Anything else?

I guess the ItemSection.target_id (which is target_id or sectionIdentifier) should be used to identify the the id of these special feeds

Checklist

  • I am running the latest version.
  • I checked the documentation and found no answer.
  • I have searched the existing issues and made sure this is not a duplicate.
  • I have provided sufficient information.
@LuanRT
Copy link
Owner

LuanRT commented Apr 17, 2024

Now that YouTube no longer has a library, just a "You" page, I say we refactor this to something more generic to avoid things breaking like this in the future..

I think simply exposing contents & header should be enough, and perhaps also a few methods (we can identify them using the browseId) to get all content for some of the shelves.

@iBicha
Copy link
Contributor Author

iBicha commented Apr 17, 2024

Now that YouTube no longer has a library, just a "You" page

For me https://www.youtube.com/feed/you and https://www.youtube.com/feed/library look exactly the same

@iBicha
Copy link
Contributor Author

iBicha commented Apr 28, 2024

PS: I thought visiting https://www.youtube.com/feed/you would browse FEmy_youtube, but it was doing FElibrary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants