Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing of axios_config #38

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Allow passing of axios_config #38

merged 1 commit into from
Oct 30, 2022

Conversation

ueda000
Copy link
Contributor

@ueda000 ueda000 commented Oct 29, 2022 •
edited

Description

Fixes closed PR #29

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ueda000 ueda000 changed the title fix: https://github.com/LuanRT/google-this/pull/29 Allow passing of axios_config Oct 29, 2022
@ueda000
feat: add axiox_config option
0a0a436 
This option will be passed to Axios config.
@ueda000
Copy link
Contributor Author

ueda000 commented Oct 29, 2022

@LuanRT
This is fix of #29.
I have confirmed the operation in my environment.

@LuanRT
Copy link
Owner

LuanRT commented Oct 30, 2022

Awesome, many thanks!

@LuanRT LuanRT merged commit bc6f629 into LuanRT:main Oct 30, 2022
@ueda000 ueda000 deleted the feature/axios_config branch October 30, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuanRT LuanRT LuanRT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ueda000 @LuanRT