Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update image origin information index #41

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

eliabefranca
Copy link
Contributor

Image Search Fix

Description

The image search feature wasn't working and was always returning an empty array.

Fixes

It seems that the index that refers to the origin changed from 9 to 22, so I just changed that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (it wasn't necessary)
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (it wasn't necessary)
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

It seems that the index that refers to the origin changed from 9 to 22.
I ran the tests and it worked fine :)
@alexandrosmagos
Copy link

Tried the code, it now returns links and fixes the current bug, but the results are completely different that what searched.

@LuanRT
Copy link
Owner

LuanRT commented Dec 11, 2022

Awesome, thanks for contributing!

@alexandrosmagos
Are you sure? I did a few tests and all results were relevant to the query used. But maybe I'm missing something or we need more context here.

For now I'll be merging this and publish a new version to NPM.

@LuanRT LuanRT merged commit 2bee7c2 into LuanRT:main Dec 11, 2022
@LuanRT LuanRT mentioned this pull request Jan 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants