Fix Python TaskMetrics.__init__ #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gatherAccumulable` was removed from the constructor from the parallel Scala TaskMetrics class; however, the Python constructor was not updated. py4j.Py4JException: Constructor ch.cern.sparkmeasure.TaskMetrics([class org.apache.spark.sql.SparkSession, class java.lang.Boolean]) does not exist
|
Just started checking it out today -- all the docs and example notebooks are super helpful! Ran into this small error, seemed like a quick fix |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gatherAccumulablewas removed from the constructor from the parallelScala TaskMetrics class; however, the Python constructor was not
updated.
In sparkmeasure pypi 0.21.0 I saw the following error upon running the Python constructor.
py4j.Py4JException: Constructor ch.cern.sparkmeasure.TaskMetrics([class org.apache.spark.sql.SparkSession, class java.lang.Boolean]) does not exist
sparkMeasure/src/main/scala/ch/cern/sparkmeasure/TaskMetrics.scala
Line 21 in 131e52b
I tested this with a local Python build and ensure that I was able to construct TaskMetrics and collect metrics.